Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting GA - Alerts documentation #89996

Closed
4 tasks done
mikecote opened this issue Feb 2, 2021 · 4 comments
Closed
4 tasks done

Alerting GA - Alerts documentation #89996

mikecote opened this issue Feb 2, 2021 · 4 comments
Assignees
Labels
Feature:Alerting Meta Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Feb 2, 2021

Originally part of #81532, this issue encapsulates the missing documentation on alerts necessary for Alerting GA.

@mikecote mikecote added Meta Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor Author

mikecote commented Feb 8, 2021

I wonder if there are some APIs we should hold off formally documenting? This would open the opportunity to make breaking changes to them in a minor release 🤔 , For example, get_alert_instance_summary, get_alert_state, aggregate. They feel very tied to our underlying architecture and it could be a pain to support if we're changing how we deal with alerts as data.

@pmuellr
Copy link
Member

pmuellr commented Feb 9, 2021

I wonder if there are some APIs we should hold off formally documenting?

Yes, I feel that pain. But I'd bet we'll get issues about missing doc for those if we don't. Could we mark them as "experimental" or something?

@mikecote
Copy link
Contributor Author

mikecote commented Feb 9, 2021

I'd bet we'll get issues about missing doc for those if we don't

I think that's fine, and we can reply that they are informal APIs. I've seen a few teams do so. For example, the dashboard export API, the saved objects relationships API, etc.

That way, if we have alerts as data, we can remove some summary APIs, it would be one thing less to maintain in the future as we can remove them and work with the internal teams that use them. If we document them as experimental, like most existing APIs, we still have some commitment to them to avoid breaking changes as much as possible.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Meta Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

5 participants