Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Source] Fields API: Do not request unmapped fields if source filtering is used #91907

Closed
majagrubic opened this issue Feb 18, 2021 · 1 comment · Fixed by #91921
Closed

[Search Source] Fields API: Do not request unmapped fields if source filtering is used #91907

majagrubic opened this issue Feb 18, 2021 · 1 comment · Fixed by #91921
Assignees
@majagrubic
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0

Comments

@majagrubic
Copy link
Contributor

When source filters are defined in an index pattern, we'll request all fields (except the ones defined with the source filter) explicitly. Once we enable unmapped fields by default, we'll add include_unmapped with each of the field: `https://github.com/elastic/kibana/blob/master/src/plugins/data/common/search/search_source/search_source.ts#L509

We need to change this logic as requesting this many fields with inlcude_unmapped option would break ES.
@majagrubic majagrubic added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@majagrubic majagrubic mentioned this issue Feb 18, 2021
Closed
31 tasks
@majagrubic majagrubic self-assigned this Feb 18, 2021
@majagrubic majagrubic mentioned this issue Feb 18, 2021
Merged
3 tasks
@majagrubic majagrubic changed the title [Search Source] Fields API: Do not request unmapped fields if source filtering is on [Search Source] Fields API: Do not request unmapped fields if source filtering is used Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majagrubic majagrubic

Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Search Source] Do not request unmapped fields if source filters are provided majagrubic/kibana
2 participants
@majagrubic @elasticmachine