-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Change a series color from the legend #92151
Comments
I will also post here @MichaelMarcialis comment:
@markov00: Here are some of my initial thoughts based on your comments. I'm coming into this conversation a bit sideways, so please feel free to schedule something on the calendar if you think further discussion is warranted.
I generally agree with this suggestion (i.e. a reduction color options offered lowers chances of user decision paralysis and helps avoid potentially poor choices). However, I do wonder about those advanced users who would desire to have greater control over their colors. For example, Grafana defaults to offering a limited selection of colors, but also has the option for users to make custom colors if they wish. It's tucked away in a separate tab, but it's available for those advanced users. Perhaps that is beyond the scope of this PR, but thought I'd mention it.
I like this idea. Do you feel that two neutral colors would be sufficient for the majority of these use cases? Have you given any thought as to what should happen to these neutral colors if the user selects the "Gray" color palette? I imagine they'd need to be conditionally removed or incorporated in some way.
This is an interesting solution to avoid inundating the user with too many color options. Perhaps as an alternative to the "Variant" slider in your mockup, we could change it to a lightness/darkness slider. The hue and saturation stays true to the chosen color palette, but the user can adjust the lightness/darkness of the available colors.
The relationship between the legend-based color picker and the color palette field in the sidebar is interesting. I like the idea that the default colors presented in the legend-based picker being pulled from the chosen color palette. However, I'm not sure about the actually changing the entire palette from within the legend-based color picker popover (assuming that is what your mockup is suggesting). I worry the user might be confused as to whether they were changing the palette for the entire visualization or just that particular value.
If you mean in terms of being consistent in our usage of the latest color palette and color picker components, I agree. |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Pinging @elastic/datavis (Feature:ElasticCharts) |
Similar to the way Lens handles this inside of the formatting flyout, the biggest improvement we can make is to allow the user to customize the actual color value. Providing a static set of 18+ colors does not provide the user with anything but the possibility of making bad choices - the "shifted" options in the list get lighter causing less contrast and harder to see. Instead, it's much more flexible to provide a simple, limited (10) set of colors that provide good defaults then let the user customize to anything. This means, more than just simply giving them the color hue and brightness matrix, but a way to provide a hex value as well. Lens does this by using the input style of color picker, but the legend can handle this easily by providing the manual input box in the popover like so: I'll agree that going further and allowing customization of the entire palette will be helpful as well. But this should live outside of the legend and cover the entire visualization as a "starting point". Still allowing further customization per series. |
note: watch for intersection of this with disabling auto-apply |
I am closing this as we decided to not take this path with the color by terms project. |
Right now, the classic visualizations allow the users to change the color of their series by letting them choose between a number of given colors.
We would love to extend this functionality by giving the user more capabilities such as choose between our palettes, have more control over the colors etc.
A discussion has started here but as it is something that may affect Lens and other plugins, it would be better to discuss it separately.
This is @markov00's comment on how he envisions the feature:
hey @stratoula @miukimiu @nickofthyme I'm not a designer but I hope this example can provide a different viewpoint on the color picker:
cc @monfera
Originally posted by @markov00 in #90589 (comment)
The text was updated successfully, but these errors were encountered: