Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Refactor Services Abstraction layer to Canvas and Dashboard #92877

Closed
clintandrewhall opened this issue Feb 25, 2021 · 4 comments
Closed

Add/Refactor Services Abstraction layer to Canvas and Dashboard #92877

clintandrewhall opened this issue Feb 25, 2021 · 4 comments
Assignees
@Heenawter
Labels
enhancement New value added to drive a business result Feature:Canvas Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@clintandrewhall
Copy link
Contributor

Builds upon #88112

We should add the new Services abstraction layer to Dashboard, and refactor Canvas to use it.

For Dashboard, this would mean building the services and finding and replacing all instances of useKibana, etc. Should go pretty quickly.

For Canvas, this would mean a larger refactor to use services only within React. In my attempts to PoC this, I found we really need to refactor Redux to make it work well.
@clintandrewhall clintandrewhall added Feature:Dashboard Dashboard related features enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort technical debt Improvement of the software architecture and operational architecture impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Canvas labels Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Related to: #91950

@ThomThomson
Copy link
Contributor

Copying from #91950, and will close that issue, because everything except for the services abstraction is finished.

Currently, the dashboard app has two different service interfaces, one for the application, and another for the embeddables and actions. These two services interfaces should be unified into one. Additionally, the new services pattern outlined in #88112 would be an excellent fit for reducing the dashboard plugin's reliance on the Kibana ecosystem.

This was referenced Jul 20, 2022
Closed
Closed
@Heenawter Heenawter self-assigned this Jul 26, 2022
@Heenawter Heenawter mentioned this issue Sep 8, 2022
Merged
3 tasks
@ThomThomson
Copy link
Contributor

Closing this because the refactor has been finished for Dashboard for a while, and we weren't able to prioritize this refactor for Canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
enhancement New value added to drive a business result Feature:Canvas Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clintandrewhall @Heenawter @ThomThomson @elasticmachine