Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect field aliases whilst exporting to CSV #93798

Closed
shaunmcgough opened this issue Mar 5, 2021 · 6 comments
Closed

Respect field aliases whilst exporting to CSV #93798

shaunmcgough opened this issue Mar 5, 2021 · 6 comments
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@shaunmcgough
Copy link

While exporting to CSV we should respect field aliases for the exported field labels.

This includes Discover, Lens, Reporting, and anywhere this is used.
@shaunmcgough shaunmcgough added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Mar 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@shaunmcgough shaunmcgough mentioned this issue Mar 5, 2021
Closed
@tsullivan
Copy link
Member

There is a PR in-flight to rewrite Reporting's CSV Export feature using a list of fields given to SearchSource: #88303 The purpose of that PR is to make CSV Export compatible with runtime fields.

Field aliases should be supported by SearchSource, so the PR should also handle this as well. We'll add a functional test to make sure.

@mattkime mattkime added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Mar 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime
Copy link
Contributor

mattkime commented Mar 5, 2021

@shaunmcgough did you mean es field aliases https://www.elastic.co/guide/en/elasticsearch/reference/master/alias.html or do you mean an index pattern field custom label?

@shaunmcgough
Copy link
Author

I am referring to es field aliases.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels May 10, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels May 13, 2021
@ppisljar
Copy link
Member

this has been resolved, please reopen if that is not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mattkime @tsullivan @shaunmcgough @ppisljar @elasticmachine @petrklapka