Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getDateMeta to store interval in custom param #93960

Closed
flash1293 opened this issue Mar 8, 2021 · 1 comment · Fixed by #95206
Closed

Change getDateMeta to store interval in custom param #93960

flash1293 opened this issue Mar 8, 2021 · 1 comment · Fixed by #95206
Assignees

Comments

@flash1293
Copy link
Contributor

flash1293 commented Mar 8, 2021

getDateMeta is a helper to extract the used date histogram of an aggregation out of the data table. It uses the fact that the applied time range is part of the meta data and does the same interval calculation as happening within agg configs.

A cleaner approach is to use a parameter which only gets serialized on the agg config which can easily read without requiring all of the actual logic (like it's done for number histograms: #91370 )

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@flash1293 flash1293 changed the title Change getNumberHistogramIntervalByDatatableColumn to store interval in custom param Change getDateMeta to store interval in custom param Mar 23, 2021
@flash1293 flash1293 self-assigned this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants