Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Workpad Templates are using demodata function for not dynamic elements (e.g. markdown) #94521

Closed
lucabelluccini opened this issue Mar 12, 2021 · 2 comments
Closed

[Canvas] Workpad Templates are using demodata function for not dynamic elements (e.g. markdown) #94521

lucabelluccini opened this issue Mar 12, 2021 · 2 comments
Assignees
@poffdeluxe
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@lucabelluccini
Copy link
Contributor

Kibana version: 7.2+ (after #35745)

Describe the bug:

The built-in Workpad templates are using demodata for static elements.
This generates 2 issues:

  • slower rendering time, due to the fact the demodata is re-generated every time on server side, making the Canvas feel slow
  • more data to be transferred

As a side effect, reporting can fail and can generate a lot of useless load on Kibana server (due to calls to /api/canvas/fns, which include demodata)

Steps to reproduce:

  1. Install Kibana
  2. Go on any Workpad template we provide
  3. Check the text elements (e.g. Markdown)
  4. Most of them contain demodata

Expected behavior:

If the markdown is not dynamic or relying on demodata, let's remove them.

Bonus:

It would be great to have a way to detect the final element rendering is static (not relying on any dynamic data) and ignore any dynamic source.
@lucabelluccini lucabelluccini added bug Fixes for quality problems that affect the customer experience Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Canvas labels Mar 12, 2021
@kibanamachine kibanamachine added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@lucabelluccini lucabelluccini mentioned this issue Mar 19, 2021
Closed
@petrklapka petrklapka added the 1 label May 10, 2021
@poffdeluxe
Copy link
Contributor

This was fixed as a part of #100714

@poffdeluxe poffdeluxe self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poffdeluxe poffdeluxe

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lucabelluccini @poffdeluxe @elasticmachine @kibanamachine @petrklapka