Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color field format should apply to the whole cell in data table #9834

Closed
tbragin opened this issue Jan 12, 2017 · 7 comments
Closed

Color field format should apply to the whole cell in data table #9834

tbragin opened this issue Jan 12, 2017 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Data Table Data table visualization feature release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@tbragin
Copy link
Contributor

tbragin commented Jan 12, 2017

The current styling of the color field formatter currently highlights just text. This does not look very clean and makes the text a bit hard to read. How about coloring the whole cell instead?

screen shot 2016-10-23 at 12 23 58 pm

@ppisljar @thomasneirynck @cjcenizal Thoughts?

@tbragin tbragin added Feature:Data Table Data table visualization feature Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement labels Jan 12, 2017
@ppisljar
Copy link
Member

  • the way field formatters are implemented at the moment this might be a bit hard to achieve. field formatters are applied on the data itself. so when I get the AggConfigResult value it was already applied (meaning that inside table i have no notion about what field formatter was applied).

  • I don't think using field formatters for this in the first place is the right solution .... (they are applied globally ... you cant control them per visualization, which you would probably want.

@elvarb
Copy link

elvarb commented Mar 7, 2017

When returning the field adding a

with the proper css to fill out the table space and apply the right color might be a good way to do this.

@cjcenizal
Copy link
Contributor

@elvarb Not sure what happened, but it looks like maybe an image or some text got cut out of your comment?

@pacurtin
Copy link

@elvarb Could you repost your comment? Investigating how to tackle this now. Any hints on a place to start would be appreciated.

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@lukeelmers lukeelmers added the enhancement New value added to drive a business result label Oct 5, 2018
@fxprunayre
Copy link
Contributor

Maybe this fxprunayre@9953d6c could be an option to make progress on this ? Truncating field when a formatter returns HTML probably does not make much sense. I'm quite new in here, so any suggestion for a better approach is welcomed too! See also https://discuss.elastic.co/t/cell-background-color-instead-of-text-only/152492

image

@elvarb
Copy link

elvarb commented Oct 16, 2018

Think my original text included a div or span html tag

@cchaos cchaos removed the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Jan 15, 2019
@ghudgins
Copy link
Contributor

ghudgins commented Jul 5, 2022

We plan on addressing this formatting requirement via Lens in #101942

Lens currently supports this style of data table coloring for number fields as of ~7.14

@ghudgins ghudgins closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Data Table Data table visualization feature release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

10 participants