Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract reporting file storage as duplex stream #98726

Closed
ppisljar opened this issue Apr 29, 2021 · 2 comments · Fixed by #106821
Closed

abstract reporting file storage as duplex stream #98726

ppisljar opened this issue Apr 29, 2021 · 2 comments · Fixed by #106821
Labels
Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort needs-team Issues missing a team label

Comments

@ppisljar
Copy link
Member

Reporting stores generated reports in elasticsearch (pdf, csv, png). In order to abstract that away and allow us to implement new storage locations in the future we will implement the current store as a duplex stream. This should make it much easier to consume as well as easier to support different streams in the future (like simple filesystem steam).

const stream = createWritableEsStream(id);
stream.write(myRawData);
stream.end();
const stream = createReadableEsStream(id);
for await (chunk in stream) {
  console.log(chunk);
}
stream.close();
@ppisljar ppisljar added AppServicesSync-7-14 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Apr 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:large Large Level of Effort and removed loe:small Small Level of Effort labels Apr 29, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 6, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 3, 2021
@sophiec20 sophiec20 added Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort needs-team Issues missing a team label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants