Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] refactoring sourcemap api to receive form-data #103152

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jun 23, 2021

new post api to upload source map:

/api/apm/sourcemaps

curl --location --request POST 'http://localhost:5601/foo/api/apm/sourcemaps' \
--header 'kbn-xsrf: teste' \
--header 'Content-Type: multipart/form-data' \
--form 'service_name="foo"' \
--form 'service_version="1.0.0"' \
--form 'bundle_filepath="/test/e2e/general-usecase/bundle.js.map"' \
--form 'sourcemap="{\"version\":3,\"file\":\"static/js/main.chunk.js\",\"sources\":[\"fleet-source-map-client/src/index.css\",\"fleet-source-map-client/src/App.js\",\"webpack:///./src/index.css?bb0a\",\"fleet-source-map-client/src/index.js\",\"fleet-source-map-client/src/reportWebVitals.js\"],\"sourcesContent\":[\"content\"],\"mappings\":\"mapping\",\"sourceRoot\":\"\"}"'

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 apm:fleet auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 23, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner June 23, 2021 18:12
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from axw June 23, 2021 18:13
@cauemarcondes
Copy link
Contributor Author

@axw is it ok to name the API /api/apm/sourcemaps?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@axw is it ok to name the API /api/apm/sourcemaps?

Yes that's fine, thanks.

@cauemarcondes cauemarcondes merged commit 5a76c84 into elastic:master Jun 24, 2021
@cauemarcondes cauemarcondes deleted the apm-sourcemap-form-data branch June 24, 2021 15:04
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 24, 2021
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:fleet auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants