-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix telemetry advanced setting style #103838
Merged
timroes
merged 1 commit into
elastic:master
from
timroes:advanced-settings/fix-telemetry-style
Jun 30, 2021
Merged
Fix telemetry advanced setting style #103838
timroes
merged 1 commit into
elastic:master
from
timroes:advanced-settings/fix-telemetry-style
Jun 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v8.0.0
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
release_note:skip
Skip the PR/issue when compiling release notes
v7.14.0
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.15.0
labels
Jun 30, 2021
Pinging @elastic/kibana-app (Team:KibanaApp) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/nodes_mb·js.Monitoring app Elasticsearch nodes listing mb with only online nodes should filter for non-existent indexStandard Out
Stack Trace
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Jun 30, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 30, 2021
…-policy-2 * 'master' of github.com:elastic/kibana: [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) # Conflicts: # x-pack/plugins/reporting/server/lib/store/store.ts
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 30, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (178 commits) [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028) [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171) [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663) fix too many rernders (elastic#103672) [APM] Add “Analyze Data” button (elastic#103485) [Lens] Fix value popover spacing (elastic#103081) [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926) [SECURITY] Adds security links to doc link service (elastic#102676) Update dependency @elastic/charts to v31 (elastic#102078) [Security Solution][CTI] Investigation time enrichment UI (elastic#103383) Adds ECS guide to doc links service (elastic#102246) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.14.0
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the style of the telemetry section that was not addressed in #101335 to match the rest of the advanced setting panels.
Before:
After: