From 1eea735c470cf5f4890c653970cc9e251d159202 Mon Sep 17 00:00:00 2001 From: cauemarcondes Date: Mon, 5 Jul 2021 11:17:50 -0400 Subject: [PATCH 1/2] using history.location instead of location --- .../components/app/error_group_details/detail_view/index.tsx | 5 +++-- .../components/shared/MetadataTable/ErrorMetadata/index.tsx | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx b/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx index be3895967d4dc..610752b7f7d98 100644 --- a/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx +++ b/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx @@ -157,9 +157,9 @@ export function DetailView({ errorGroup, urlParams }: Props) { { history.replace({ - ...location, + ...history.location, search: fromQuery({ - ...toQuery(location.search), + ...toQuery(history.location.search), detailTab: key, }), }); @@ -189,6 +189,7 @@ function TabContent({ const exceptions = error.error.exception || []; const logStackframes = error.error.log?.stacktrace; + console.log('### caue ~ currentTab.key', currentTab.key); switch (currentTab.key) { case logStacktraceTab.key: return ( diff --git a/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx b/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx index 196a8706d5132..ee53baba18f63 100644 --- a/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx +++ b/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx @@ -16,6 +16,7 @@ interface Props { } export function ErrorMetadata({ error }: Props) { + console.log('### caue ~ error', error); const sectionsWithRows = useMemo( () => getSectionsWithRows(ERROR_METADATA_SECTIONS, error), [error] From 0a9d7154c58057c3966450a64dc50dfad368e4ef Mon Sep 17 00:00:00 2001 From: cauemarcondes Date: Mon, 5 Jul 2021 11:19:06 -0400 Subject: [PATCH 2/2] removing consoles --- .../components/app/error_group_details/detail_view/index.tsx | 1 - .../components/shared/MetadataTable/ErrorMetadata/index.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx b/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx index 610752b7f7d98..5a56b64374537 100644 --- a/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx +++ b/x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx @@ -189,7 +189,6 @@ function TabContent({ const exceptions = error.error.exception || []; const logStackframes = error.error.log?.stacktrace; - console.log('### caue ~ currentTab.key', currentTab.key); switch (currentTab.key) { case logStacktraceTab.key: return ( diff --git a/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx b/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx index ee53baba18f63..196a8706d5132 100644 --- a/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx +++ b/x-pack/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx @@ -16,7 +16,6 @@ interface Props { } export function ErrorMetadata({ error }: Props) { - console.log('### caue ~ error', error); const sectionsWithRows = useMemo( () => getSectionsWithRows(ERROR_METADATA_SECTIONS, error), [error]