Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] fix include/exclude fields appear to migrated TSVB visualization when using Group by Terms #104848

Merged
merged 3 commits into from
Jul 9, 2021
Merged

[TSVB] fix include/exclude fields appear to migrated TSVB visualization when using Group by Terms #104848

merged 3 commits into from
Jul 9, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 8, 2021 •
edited
Loading

Closes: #104829

Summary

Describe the bug:

Migrated the [Logs] Response Codes Over Time + Annotations from 7.12 to 7.14-BC and the Include/Exclude fields are now showing up in the Group by section of the configuration.

Migrated TSVB chart from 7.12 to 7.14:

Screenshot 2021-07-08 at 11 00 17

Same visualization in 7.14 "clean":

Screenshot 2021-07-08 at 11 01 25

Steps to reproduce:

  1. Bootstrap a 7.12 instance and load the sample logs dataset
  2. Shutdown the 7.12 instance and bootstrap a 7.14 instance
  3. Open the [Logs] Response Codes Over Time + Annotations visualization

@alexwizp alexwizp self-assigned this Jul 8, 2021
@alexwizp alexwizp added v7.15.0 v8.0.0 regression release_note:fix Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 8, 2021
@alexwizp alexwizp changed the title [TSVB] Include/exclude fields appear to migrated TSVB visualization when using Group by Terms [TSVB] fix include/exclude fields appear to migrated TSVB visualization when using Group by Terms Jul 8, 2021
@alexwizp alexwizp requested review from VladLasitsa and stratoula July 8, 2021 11:53
@alexwizp alexwizp marked this pull request as ready for review July 8, 2021 14:04
@alexwizp alexwizp requested a review from a team July 8, 2021 14:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Can we add a test in order to not lose it again?

stratoula
stratoula approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for the test! Code LGTM, please merge in case of green CI

@alexwizp alexwizp enabled auto-merge (squash) July 9, 2021 13:21
@alexwizp alexwizp added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1007.3KB 1007.7KB +366.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit ef991b7 into elastic:master Jul 9, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.14 Commit could not be cherrypicked due to conflicts
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 104848

@alexwizp alexwizp mentioned this pull request Jul 9, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 9, 2021
@alexwizp
[TSVB] fix include/exclude fields appear to migrated TSVB visualizati…
7ec2804 
…on when using Group by Terms (elastic#104848)

* [TSVB] Include/exclude fields appear to migrated TSVB visualization when using Group by Terms

Closes: elastic#104829

* add functional test

* fix JEST
# Conflicts:
#	test/functional/page_objects/visual_builder_page.ts
@alexwizp alexwizp mentioned this pull request Jul 9, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 9, 2021
@alexwizp
[TSVB] fix include/exclude fields appear to migrated TSVB visualizati…
9ce72bc 
…on when using Group by Terms (elastic#104848)

* [TSVB] Include/exclude fields appear to migrated TSVB visualization when using Group by Terms

Closes: elastic#104829

* add functional test

* fix JEST
# Conflicts:
#	test/functional/page_objects/visual_builder_page.ts
alexwizp added a commit that referenced this pull request Jul 9, 2021
@alexwizp
[TSVB] fix include/exclude fields appear to migrated TSVB visualizati…
a037e19 
…on when using Group by Terms (#104848) (#105069)

* [TSVB] Include/exclude fields appear to migrated TSVB visualization when using Group by Terms

Closes: #104829

* add functional test

* fix JEST
# Conflicts:
#	test/functional/page_objects/visual_builder_page.ts
alexwizp added a commit that referenced this pull request Jul 9, 2021
@alexwizp
[TSVB] fix include/exclude fields appear to migrated TSVB visualizati…
86d34d4 
…on when using Group by Terms (#104848) (#105068)

* [TSVB] Include/exclude fields appear to migrated TSVB visualization when using Group by Terms

Closes: #104829

* add functional test

* fix JEST
# Conflicts:
#	test/functional/page_objects/visual_builder_page.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:TSVB TSVB (Time Series Visual Builder) regression release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Include/exclude fields appear to migrated TSVB visualization when using Group by Terms
4 participants
@alexwizp @elasticmachine @kibanamachine @stratoula