Cumulative set of the preboot stage adjustments #108514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
Team:Core
azasypkin
force-pushed
the
issue-xxx-preboot-adjustments
branch
from
b6f932f to
a765a1f
Compare
15 tasks
…endered as a normal, not anonymous app.
…endered as a normal, not anonymous app, expose `getServerInfo`.
azasypkin
force-pushed
the
issue-xxx-preboot-adjustments
branch
from
a765a1f to
3d6d1f3
Compare
|
Pinging @elastic/kibana-core (Team:Core) |
1 task
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Aug 23, 2021
💚 Build SucceededMetrics [docs]History
To update your PR or re-run it, just comment with: cc @azasypkin |
azasypkin
added a commit
that referenced
this pull request
Aug 23, 2021
# Conflicts: # src/plugins/interactive_setup/server/elasticsearch_service.test.ts # src/plugins/interactive_setup/server/elasticsearch_service.ts # src/plugins/interactive_setup/server/routes/enroll.test.ts # src/plugins/interactive_setup/server/routes/enroll.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few updates in the Core to required by the Interactive Setup mode:
renderCoreAppinstead ofrenderAnonymousCoreAppto render preboot client-side apps since there is no Security at the preboot stage anyway. We had a UI settings inconsistency issue because ofrenderAnonymousCoreAppsince, when Security is not enabled, Core uses default UI settings when it renders anonymous apps, but still respects UI overrides (e.g. fromkibana.yml) inbootstrapRenderer.caFingerprintES client parameter. I didn't expose it to theelasticsearch.*config as there is no such need yet.getServerInfofrom the preboot HTTP service contract.Blocked by: #109414