[Infrastructure UI] Host limit telemetry #155726

crespocarlos · 2023-04-25T14:31:17Z

Summary

This PR adds a new custom event to track the total number of hosts, as well as adjusts a few data-test-subj attribute values to meet the naming convention defined in the observability-dev docs

For Reviewers

An option for not allowing yet a new custom event in FS could be triggering the new custom events only for self-managed customers, and in FS watch the element that holds the total number of hosts. But for now, I decided to allow the new custom event in FS for consistency

apmmachine · 2023-04-25T14:31:38Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-04-25T15:58:28Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

TinaHeiligers

LGTM

jennypavlova

LGTM 🚀

afharo

LGTM

afharo · 2023-04-26T18:22:50Z

x-pack/plugins/cloud_integrations/cloud_full_story/server/config.ts

@@ -24,6 +24,7 @@ const configSchema = schema.object({
      'Host Entry Clicked', // Worst-case scenario once per second - AT RISK,
      'Host Flyout Filter Removed', // Worst-case scenario once per second - AT RISK,
      'Host Flyout Filter Added', // Worst-case scenario once per second - AT RISK,
+      'Host View Total Host Count Retrieved', // Worst-case scenario 1 every 2 seconds


cc @shahinakmal FYI, this PR adds another custom event to FS

afharo

After checking with @shahinakmal, we shouldn't allow more custom events to be sent to FS.

roshan-elastic · 2023-04-27T13:51:24Z

Update:

I'm meeting @shahinakmal on Friday to walk through how we can answer the Qs we want with this custom event but only using the telemetry cluster

Context : FullStory Custom Events doesn't look like a scalable solution due to rate limits so it looks like we won't be able to use them moving forward unless absolutely necessary. Hoping we can use the telemetry cluster etc do do this analysis instead.

After that call, we'll make a call on whether the event needs to be whitelisted in FS.

roshan-elastic · 2023-05-09T11:08:53Z

Hey @crespocarlos @shahinakmal - quick update:

@shahinakmal and I walked through the telemetry on Friday
We were able to get the data we wanted for this (but with caveats)
We are only able to get very small time periods of data - e.g. maybe 15-30 minutes of data before the UI is too slow
We need to be able to get weeks/days/months worth of data to make decisions based on the telemetry (something FullStory allowed)

As it stands, without the FullStory custom event - we're not getting the telemetry we need.

I'll send an email internally for next steps on this...

…y-host-limit

roshan-elastic · 2023-05-11T12:53:15Z

Hey @crespocarlos - we can remove the FS whitelisting here and go ahead with this (we'll try to live without the FS custom events given the throttling issues).

OK to proceed on this one?

@shahinakmal FYI - we'll remove it and go ahead as suggested (i.e. we'll use the telemetry cluster instead of FS for these custom events).

crespocarlos · 2023-05-11T14:14:44Z

@elasticmachine merge upstream

afharo

Thank you for iterating! LGTM

kibana-ci · 2023-05-11T15:18:00Z

💚 Build Succeeded

Buildkite Build
Commit: f402f4b

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	2.0MB	2.0MB	+139.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	101.7KB	102.1KB	+418.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	480	484	+4
total			+6

History

💔 Build #127133 failed 2023f4c
💛 Build #126675 was flaky 6a31f07
💔 Build #126666 failed 7224e56
💔 Build #126586 failed 593569f
💚 Build #123199 succeeded 0c05d02

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

closes: elastic#155567 ## Summary This PR adds a new custom event to track the total number of hosts, as well as adjusts a few `data-test-subj` attribute values to meet the naming convention defined in the observability-dev [docs](https://github.com/elastic/observability-dev/blob/main/docs/how-we-work/telemetry/telemetry-convention.md#naming-convention) ### For Reviewers An option for not allowing yet a new custom event in FS could be triggering the new custom events only for self-managed customers, and in FS watch the element that holds the total number of hosts. But for now, I decided to allow the new custom event in FS for consistency --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 937912b)

kibanamachine · 2023-05-11T15:51:48Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.8`: - [[Infrastructure UI] Host limit telemetry (#155726)](#155726)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>

Add host limit telemetry

2224bf6

crespocarlos force-pushed the 155576-telemetry-host-limit branch from cf662b4 to 2224bf6 Compare April 25, 2023 14:55

crespocarlos marked this pull request as ready for review April 25, 2023 15:58

crespocarlos requested review from a team as code owners April 25, 2023 15:58

TinaHeiligers approved these changes Apr 25, 2023

View reviewed changes

crespocarlos requested a review from afharo April 25, 2023 16:19

Fix data-test-subj

0c05d02

jennypavlova approved these changes Apr 26, 2023

View reviewed changes

afharo approved these changes Apr 26, 2023

View reviewed changes

afharo requested changes Apr 26, 2023

View reviewed changes

crespocarlos added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.9.0 and removed backport:skip This commit does not require backporting v8.8.0 labels May 2, 2023

crespocarlos added 3 commits May 9, 2023 11:22

Merge branch 'main' of github.com:elastic/kibana into 155576-telemetr…

593569f

…y-host-limit

Fix test

7224e56

Merge branch 'main' of github.com:elastic/kibana into 155576-telemetr…

6a31f07

…y-host-limit

Removing host limit custom event from FS allow list

2023f4c

crespocarlos requested a review from afharo May 11, 2023 13:16

Merge branch 'main' into 155576-telemetry-host-limit

f402f4b

afharo reviewed May 11, 2023

View reviewed changes

afharo approved these changes May 11, 2023

View reviewed changes

crespocarlos merged commit 937912b into elastic:main May 11, 2023

kibanamachine mentioned this pull request May 11, 2023

[8.8] [Infrastructure UI] Host limit telemetry (#155726) #157409

Merged

kibanamachine added the v8.8.0 label May 11, 2023

iblancof mentioned this pull request Dec 2, 2024

[Infra] Send Host View Total Host Count Retrieved event on every query submission in hosts inventory #202441

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infrastructure UI] Host limit telemetry #155726

[Infrastructure UI] Host limit telemetry #155726

crespocarlos commented Apr 25, 2023 •

edited by kibanamachine

Loading

apmmachine commented Apr 25, 2023

elasticmachine commented Apr 25, 2023

TinaHeiligers left a comment

jennypavlova left a comment

afharo left a comment

afharo Apr 26, 2023

afharo left a comment

roshan-elastic commented Apr 27, 2023

roshan-elastic commented May 9, 2023

roshan-elastic commented May 11, 2023

crespocarlos commented May 11, 2023

afharo left a comment

kibana-ci commented May 11, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented May 11, 2023

[Infrastructure UI] Host limit telemetry #155726

[Infrastructure UI] Host limit telemetry #155726

Conversation

crespocarlos commented Apr 25, 2023 • edited by kibanamachine Loading

Summary

For Reviewers

apmmachine commented Apr 25, 2023

🤖 GitHub comments

elasticmachine commented Apr 25, 2023

TinaHeiligers left a comment

Choose a reason for hiding this comment

jennypavlova left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

afharo Apr 26, 2023

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

roshan-elastic commented Apr 27, 2023

roshan-elastic commented May 9, 2023

roshan-elastic commented May 11, 2023

crespocarlos commented May 11, 2023

afharo left a comment

Choose a reason for hiding this comment

kibana-ci commented May 11, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented May 11, 2023

💚 All backports created successfully

Questions ?

crespocarlos commented Apr 25, 2023 •

edited by kibanamachine

Loading