Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Hidding UP tab for RUM #167608

Merged
merged 4 commits into from
Sep 29, 2023
Merged

[APM] Hidding UP tab for RUM #167608

merged 4 commits into from
Sep 29, 2023

Conversation

cauemarcondes
Copy link
Contributor

Screenshot 2023-09-29 at 10 12 24 Screenshot 2023-09-29 at 10 12 30

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 29, 2023
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 29, 2023 09:14
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

yngrdyn
yngrdyn approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 29, 2023 10:59
@yngrdyn
Copy link
Contributor

yngrdyn commented Sep 29, 2023

You might need just to wait for this one to be merged in master.

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 29, 2023 14:35
@cauemarcondes cauemarcondes merged commit aa065b7 into elastic:main Sep 29, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB +254.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 29, 2023
@cauemarcondes cauemarcondes deleted the profiling-apm-hide-tab branch September 30, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

@achyutjhunjhunwala achyutjhunjhunwala Awaiting requested review from achyutjhunjhunwala

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cauemarcondes @elasticmachine @apmmachine @yngrdyn @kibana-ci @achyutjhunjhunwala @kibanamachine