Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Reverting manual memory fix for cypress post upgrade #167733

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Oct 2, 2023

Summary

As part of this PR, added a logic to handle hiding of Logs Panels which was consuming a lot of memory.

With Cypress Upgrade to 13.x, this issue is now fixed and hence this can be reverted.

How to be sure this works ?

If the PR passes the build, you know it works

@achyutjhunjhunwala achyutjhunjhunwala added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes labels Oct 2, 2023
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner October 2, 2023 08:38
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Oct 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) October 2, 2023 08:55
@achyutjhunjhunwala achyutjhunjhunwala merged commit 843dec4 into elastic:main Oct 2, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 2, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the reverting-memory-fix-for-cypress branch October 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants