-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add back minBarHeight on discover histogram #168644
Conversation
If this feature is no longer desirable, I'm happy to close this PR. |
…-ref HEAD~1..HEAD --fix'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unified Histogram changes LGTM, thanks!
@nickofthyme thanx, I think we should def do this at least for Discover. Let's not merge it until Monday that we have our weekly sync. If we decide to add it as a setting to Lens then we don't need the overrides, we will just pass it as a property to the embeddable state. |
We decided to add this in Lens by default, only 1px though. We can make the changes in this PR or another. @nickofthyme whatever you want! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stratoula Could you please take a look at these changes and lmk if I'm on the right track? The lens embeddable logic is still very strange to me. Thanks!
src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts
Show resolved
Hide resolved
@nickofthyme you are definitely on the right track. You need to add this both in chart_expressions and in Lens. Also does it make sense to add it as an option in the toolbar? I don't remember what we agreed tbh. |
src/plugins/chart_expressions/expression_xy/common/__mocks__/index.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @nickofthyme |
Pinging @elastic/kibana-visualizations for final review 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
Summary
Adds back min bar height to discover for large document count variances per #68436
Details
The option for
minBarHeight
was likely removed from the discover histogram in process of migrating to Lens embeddable.This PR adds a new
minBarHeight
option to the Lens embeddable args, this option is passed to allBarSeries
in theDataLayer
. This option optional and defaults to1px
.Finally this value of
minBarHeight
is set to2px
for the unified histogram chart.Before
After
Checklist