Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] Fix single quotes on field save confirm toast #184789

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[data views] Fix single quotes on field save confirm toast #184789

merged 2 commits into from
Jun 5, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jun 5, 2024 •
edited
Loading

Summary

Address two cases where single quotes needed to be doubled up to prevent escaping of string interpolation. Also addressed some doc examples.

Verify confirm toasts after saving field in discover and creating a scripted field in data view management.

Follow up to #179506

@mattkime
Copy link
Contributor Author

mattkime commented Jun 5, 2024

/ci

@mattkime mattkime self-assigned this Jun 5, 2024
@mattkime mattkime added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes labels Jun 5, 2024
@mattkime mattkime changed the title fix some single quote issues [data views] Fix single quotes on field save confirm toast Jun 5, 2024
@mattkime mattkime marked this pull request as ready for review June 5, 2024 01:27
@mattkime mattkime requested review from a team as code owners June 5, 2024 01:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

...view_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx Outdated Show resolved Hide resolved
@mattkime @jughosta
Update src/plugins/data_view_management/public/components/edit_index_…
f644c98 
…pattern/create_edit_field/create_edit_field.tsx

Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
@mattkime
Copy link
Contributor Author

mattkime commented Jun 5, 2024

/ci

Bamieh
Bamieh approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! these will be automatically caught once the tooling PR is merged. currently work in progress so i appreciate fixing any messages that slipped through.

@mattkime mattkime enabled auto-merge (squash) June 5, 2024 11:09
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewFieldEditor 176.3KB 176.3KB +2.0B
dataViewManagement 136.5KB 136.5KB +4.0B
total +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit 8a5ed87 into elastic:main Jun 5, 2024
19 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@jughosta jughosta jughosta approved these changes

Assignees

@mattkime mattkime

Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattkime @elasticmachine @kibana-ci @jughosta @Bamieh @kibanamachine