Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Saved Objects Tagging] Visually hide tags in Saved Objects Management #197423

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[Saved Objects Tagging] Visually hide tags in Saved Objects Management #197423

merged 2 commits into from
Oct 24, 2024

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Oct 23, 2024 •
edited
Loading

Summary

This PR visually hides objects with tag type from Saved Objects Management table while still allowing them to be exportable.

Closes: #147786

@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Saved Object Tagging Saved Objects Tagging feature Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Oct 23, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team October 23, 2024 12:26
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 23, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner October 23, 2024 12:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kowalczyk-krzysztof kowalczyk-krzysztof removed the request for review from a team October 23, 2024 12:30
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsManagement 84.6KB 84.6KB +64.0B

cc @kowalczyk-krzysztof

TinaHeiligers
TinaHeiligers approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit e0ef5b3 into elastic:main Oct 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
backport:skip This commit does not require backporting Feature:Saved Object Tagging Saved Objects Tagging feature release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide Tags from saved object management section
4 participants
@kowalczyk-krzysztof @elasticmachine @TinaHeiligers @kibanamachine