[new-platform] Improve naming and consistency in Plugin types #34725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform |
joshdover
force-pushed
the
cleanup-dependency-naming
branch
from
1c68c59 to
a8b8d3f
Compare
💚 Build Succeeded |
💚 Build Succeeded |
rudolf
reviewed
Apr 9, 2019
💔 Build Failed |
💚 Build Succeeded |
rudolf
approved these changes
Apr 10, 2019
src/core/public/plugins/plugin.ts
Outdated
| @@ -84,7 +84,7 @@ export class PluginWrapper< | |||
| * @param dependencies The dictionary where the key is the dependency name and the value | |||
| * is the contract returned by the dependency's `setup` function. | |||
| */ | |||
| public async setup(setupContext: PluginSetupContext, dependencies: TDependenciesSetup) { | |||
| public async setup(setupContext: PluginSetupContext, dependencies: TPluginsSetup) { | |||
There was a problem hiding this comment.
Not as critical as the public API, but probably worth making this dependency paramater consistent too
src/core/server/plugins/plugin.ts
Outdated
| @@ -176,7 +189,7 @@ export class Plugin< | |||
| * @param dependencies The dictionary where the key is the dependency name and the value | |||
| * is the contract returned by the dependency's `setup` function. | |||
| */ | |||
| public async setup(setupContext: PluginSetupContext, dependencies: TDependenciesSetup) { | |||
| public async setup(setupContext: PluginSetupContext, dependencies: TPluginsSetup) { | |||
There was a problem hiding this comment.
another dependency parameter
💚 Build Succeeded |
joshdover
added a commit
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improves the naming and consistency of the types for the
PluginServices between the public and server versions.Plugininterface for server plugins.setupcan return a Promise for server plugins.