Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table Visualization] (Step 2) Shim new platform - renaming table_vis -> vis_type_table #41872

Merged
merged 4 commits into from
Jul 26, 2019
Merged

[Table Visualization] (Step 2) Shim new platform - renaming table_vis -> vis_type_table #41872

merged 4 commits into from
Jul 26, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 24, 2019 •
edited by lukeelmers
Loading

Summary

Part of #38245

2 Step of migrating to new Platform

What was done in this PR:

  • The existing [Table Visualization] plugin was moved into its own dedicated vis_type_table plugin that adheres to the new platform plugin structure.
  • localization key for plugin was changed from table_vis -> vis_type_table

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp requested a review from a team as a code owner July 24, 2019 09:47
@alexwizp alexwizp added Feature:Data Table Data table visualization feature Feature:New Platform v7.4.0 v8.0.0 :AppArch release_note:skip Skip the PR/issue when compiling release notes labels Jul 24, 2019
@alexwizp alexwizp self-assigned this Jul 24, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cchaos
cchaos approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SASS file moves 👍

lukeelmers
lukeelmers requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note, otherwise LGTM. Thanks for splitting up the PRs like this; makes it so much easier/faster to review ❤️

src/legacy/core_plugins/vis_type_table/index.ts Outdated Show resolved Hide resolved
@lukeelmers lukeelmers mentioned this pull request Jul 24, 2019
Merged
7 tasks
@alexwizp alexwizp requested a review from lukeelmers July 25, 2019 08:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp merged commit 9dbb00e into elastic:master Jul 26, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 26, 2019
@alexwizp
[Table Visualization] (Step 2) Shim new platform - renaming table_vis…
4a796c0 
… -> vis_type_table (elastic#41872)

* [Table Visualization] (Step 2) Shim new platform - renaming table_vis -> vis_type_table

* fix PR comment
@alexwizp alexwizp mentioned this pull request Jul 26, 2019
Merged
alexwizp added a commit that referenced this pull request Jul 26, 2019
@alexwizp
[Table Visualization] (Step 2) Shim new platform - renaming table_vis…
bb7aaf2 
… -> vis_type_table (#41872) (#42090)

* [Table Visualization] (Step 2) Shim new platform - renaming table_vis -> vis_type_table

* fix PR comment
@alexwizp alexwizp mentioned this pull request Jul 30, 2019
Closed
8 tasks
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@alexwizp alexwizp deleted the table_vis_renaming branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@cchaos cchaos cchaos approved these changes

@nreese nreese Awaiting requested review from nreese

@lizozom lizozom Awaiting requested review from lizozom

@streamich streamich Awaiting requested review from streamich

Assignees

@alexwizp alexwizp

Labels
Feature:Data Table Data table visualization feature Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @cchaos @lukeelmers