-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor, deangularize courier/search source #45235
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
9aa6e48
Initial refactor of search source
lukasolson 039c507
Add abort signal to search source fetch and remove cancel queued
lukasolson fb1f959
Remove usages of Angular Promises
lukasolson 1a40af4
Remove usages of angular "sessionId" service
lukasolson 6331629
Merge branch 'master' into refactorSearchSource
lukasolson 8aa6496
Remove config as dependency
lukasolson 027f6b6
Update deps on config and esShardTimeout
lukasolson ae21ec8
Remove remaining angular dependencies from SearchSource
lukasolson ac12f45
Merge branch 'master' into refactorSearchSource
lukasolson 493f882
Fix Karma tests
lukasolson 68e7529
Separate callClient and handleResponse and add tests for each
lukasolson dcbcded
Merge branch 'master' into refactorSearchSource
lukasolson ca27f89
Add tests for fetchSoon
lukasolson 9ff10c4
Add back search source test and convert to jest
lukasolson fa1ad58
Create search strategy registry test
lukasolson aa87511
Revert empty test
lukasolson 43305ec
Remove filter predicates from search source
lukasolson 6240738
Merge branch 'master' into refactorSearchSource
lukasolson df0a353
Update typings and throw response errors
lukasolson 5496403
Fix proxy to properly return response from ES
lukasolson 2c23fe5
Merge branch 'master' into refactorSearchSource
lukasolson 41567df
Update jest snapshots
lukasolson c1e1ddb
Remove unused translations
lukasolson b3e8d11
Don't pass search request to onRequestStart, create it afterwards
lukasolson 649e6fa
Fix search source & get search params tests
lukasolson 6fb788c
Merge branch 'master' into refactorSearchSource
lukasolson 7c6b7b8
Merge branch 'master' into refactorSearchSource
lukasolson 1a44042
Merge branch 'master' into refactorSearchSource
lukasolson 0d7c97d
Fix issue with angular scope not firing after setting state on vis
lukasolson 54f0a98
Merge branch 'master' into refactorSearchSource
lukasolson 60122b4
Fix tag cloud vis
lukasolson eca50a9
Fix setting of visConfig to not happen async
lukasolson 04a423c
Remove unused snapshots
lukasolson e1399bb
Merge branch 'master' into refactorSearchSource
lukasolson e29142a
Merge branch 'master' into refactorSearchSource
lukasolson 2a6d8e3
Merge branch 'master' into refactorSearchSource
lukasolson 441aa2b
Remove unused reference to IPrivate
lukasolson 3f59890
Merge branch 'master' into refactorSearchSource
lukasolson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
359 changes: 0 additions & 359 deletions
359
src/legacy/ui/public/courier/fetch/__tests__/call_client.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individual calls to
searchSource.fetch()
are now responsible for aborting those requests when they see fit.