Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, deangularize courier/search source #45235

Merged
merged 38 commits into from
Oct 18, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
9aa6e48
Initial refactor of search source
lukasolson Sep 10, 2019
039c507
Add abort signal to search source fetch and remove cancel queued
lukasolson Sep 10, 2019
fb1f959
Remove usages of Angular Promises
lukasolson Sep 11, 2019
1a40af4
Remove usages of angular "sessionId" service
lukasolson Sep 11, 2019
6331629
Merge branch 'master' into refactorSearchSource
lukasolson Sep 13, 2019
8aa6496
Remove config as dependency
lukasolson Sep 13, 2019
027f6b6
Update deps on config and esShardTimeout
lukasolson Sep 23, 2019
ae21ec8
Remove remaining angular dependencies from SearchSource
lukasolson Sep 24, 2019
ac12f45
Merge branch 'master' into refactorSearchSource
lukasolson Sep 24, 2019
493f882
Fix Karma tests
lukasolson Sep 24, 2019
68e7529
Separate callClient and handleResponse and add tests for each
lukasolson Sep 25, 2019
dcbcded
Merge branch 'master' into refactorSearchSource
lukasolson Sep 25, 2019
ca27f89
Add tests for fetchSoon
lukasolson Sep 25, 2019
9ff10c4
Add back search source test and convert to jest
lukasolson Sep 25, 2019
fa1ad58
Create search strategy registry test
lukasolson Sep 25, 2019
aa87511
Revert empty test
lukasolson Sep 25, 2019
43305ec
Remove filter predicates from search source
lukasolson Sep 26, 2019
6240738
Merge branch 'master' into refactorSearchSource
lukasolson Sep 30, 2019
df0a353
Update typings and throw response errors
lukasolson Oct 2, 2019
5496403
Fix proxy to properly return response from ES
lukasolson Oct 2, 2019
2c23fe5
Merge branch 'master' into refactorSearchSource
lukasolson Oct 3, 2019
41567df
Update jest snapshots
lukasolson Oct 3, 2019
c1e1ddb
Remove unused translations
lukasolson Oct 3, 2019
b3e8d11
Don't pass search request to onRequestStart, create it afterwards
lukasolson Oct 3, 2019
649e6fa
Fix search source & get search params tests
lukasolson Oct 3, 2019
6fb788c
Merge branch 'master' into refactorSearchSource
lukasolson Oct 3, 2019
7c6b7b8
Merge branch 'master' into refactorSearchSource
lukasolson Oct 4, 2019
1a44042
Merge branch 'master' into refactorSearchSource
lukasolson Oct 7, 2019
0d7c97d
Fix issue with angular scope not firing after setting state on vis
lukasolson Oct 8, 2019
54f0a98
Merge branch 'master' into refactorSearchSource
lukasolson Oct 14, 2019
60122b4
Fix tag cloud vis
lukasolson Oct 14, 2019
eca50a9
Fix setting of visConfig to not happen async
lukasolson Oct 14, 2019
04a423c
Remove unused snapshots
lukasolson Oct 14, 2019
e1399bb
Merge branch 'master' into refactorSearchSource
lukasolson Oct 15, 2019
e29142a
Merge branch 'master' into refactorSearchSource
lukasolson Oct 15, 2019
2a6d8e3
Merge branch 'master' into refactorSearchSource
lukasolson Oct 16, 2019
441aa2b
Remove unused reference to IPrivate
lukasolson Oct 16, 2019
3f59890
Merge branch 'master' into refactorSearchSource
lukasolson Oct 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/legacy/ui/public/courier/courier.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,14 @@ import { uiModules } from '../modules';
import { addFatalErrorCallback } from '../notify';
import '../promises';

import { searchRequestQueue } from './search_request_queue';
import { FetchSoonProvider } from './fetch';
import { SearchPollProvider } from './search_poll';
import { SearchPoll } from './search_poll';

uiModules.get('kibana/courier').service('courier', ($rootScope, Private) => {
const fetchSoon = Private(FetchSoonProvider);

// This manages the doc fetch interval.
const searchPoll = Private(SearchPollProvider);
const searchPoll = new SearchPoll();

class Courier {
constructor() {
Expand All @@ -62,13 +61,6 @@ uiModules.get('kibana/courier').service('courier', ($rootScope, Private) => {
// resume polling.
searchPoll.pause();

// And abort all pending requests.
searchRequestQueue.abortAll();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Individual calls to searchSource.fetch() are now responsible for aborting those requests when they see fit.


if (searchRequestQueue.getCount()) {
throw new Error('Aborting all pending requests failed.');
}

refreshIntervalSubscription.unsubscribe();
});

Expand Down
359 changes: 0 additions & 359 deletions src/legacy/ui/public/courier/fetch/__tests__/call_client.js

This file was deleted.

Loading