Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL field formatter fix #46332

Merged
merged 8 commits into from
Oct 1, 2019
Merged

URL field formatter fix #46332

merged 8 commits into from
Oct 1, 2019

Conversation

gospodarsky
Copy link

@gospodarsky gospodarsky commented Sep 23, 2019 •
edited
Loading

Summary

#35235

URL field formatter doesn't render relative hyperlinks properly until the fix.

It has been tested in such situations and works fine now.

Screen Shot 2019-09-26 at 2 20 41 PM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@gospodarsky gospodarsky self-assigned this Sep 23, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp requested a review from ppisljar September 26, 2019 15:12
@alexwizp alexwizp self-requested a review September 30, 2019 11:34
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gospodarsky gospodarsky merged commit 69bbd11 into elastic:master Oct 1, 2019
@gospodarsky gospodarsky mentioned this pull request Oct 1, 2019
Merged
gospodarsky pushed a commit that referenced this pull request Oct 1, 2019
URL field formatter fix (#46332) (#47016)
0c15696 
* Fix url render relative hyperlinks

* Fix test cases

* Make prefix less errorable

* Add some tests for url formatter
@gospodarsky gospodarsky mentioned this pull request Oct 7, 2019
Closed
@sulemanof sulemanof mentioned this pull request Oct 7, 2019
Merged
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Oct 7, 2019
@sulemanof
URL field formatter fix (elastic#46332)
224ffd5 
* Fix url render relative hyperlinks

* Fix test cases

* Make prefix less errorable

* Add some tests for url formatter
@gospodarsky gospodarsky added v7.5.0 and removed v7.4.1 labels Oct 7, 2019
sulemanof added a commit that referenced this pull request Oct 7, 2019
@sulemanof
URL field formatter fix (#46332) (#47464)
2d04d70 
* Fix url render relative hyperlinks

* Fix test cases

* Make prefix less errorable

* Add some tests for url formatter
@alexfrancoeur alexfrancoeur mentioned this pull request Oct 8, 2019
Closed
@AlonaNadler
Copy link

can we backport to 7.3.x?

@gospodarsky
Copy link
Author

can we backport to 7.3.x?

I can try but is it allowed to backport in the current version?

@ppisljar
Copy link
Member

i don't think there is another 7.3 release planned

@bhavyarm
Copy link
Contributor

So this fix didn't make it in 7.4.1. Can we also please get a test please? Thanks! cc @LeeDr

@rayafratkina rayafratkina mentioned this pull request Oct 30, 2019
Merged
@timroes timroes added the v8.0.0 label Oct 30, 2019
@alexwizp
Copy link
Contributor

Issue was fixed here: #49326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees

@gospodarsky gospodarsky

Labels
backported Feature:FieldFormatters release_note:fix v7.4.2 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gospodarsky @elasticmachine @AlonaNadler @ppisljar @bhavyarm @alexwizp @timroes @sulemanof @rayafratkina