-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enrich policy endpoint definitions and support for registering X-Pack processors to Console #48258
Add enrich policy endpoint definitions and support for registering X-Pack processors to Console #48258
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Jake! I'll implement my one suggestion and push to your branch unless you object.
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to prepopulate the type body with the required fields when a user selects match
or geo_match
from the autocomplete suggestions? If so, you can specify __template
fields for these types like this:
{
"enrich.put_policy": {
"data_autocomplete_rules": {
"geo_match": {
"__template": {
"indices": "",
"match_field": "",
"enrich_fields": []
},
"indices": "",
"match_field": "",
"enrich_fields": []
},
"match": {
"__template": {
"indices": "",
"match_field": "",
"enrich_fields": []
},
"indices": "",
"match_field": "",
"enrich_fields": []
}
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! thanks for adding it.
@jakelandis I've added the Enrich Processor definition. Does this look right to you? |
@cjcenizal - looking good. There are some common ones that apply to every processor "if", "ignore_failure", "on_failure", and "tag". Full doc here: https://www.elastic.co/guide/en/elasticsearch/reference/master/enrich-processor.html . Those should be included in the auto-complete help as well: (screen shot from the drop processor, which only has the common options) |
Thanks Jake! They are already included here: https://github.com/elastic/kibana/pull/48258/files#diff-53e7286e790789c23a871939f1bb6e16R8. Here's a screenshot as proof (values shown are the default value that gets filled in once you select the autocomplete suggestion): |
@cjcenizal - thanks ! tested locally and changes LGTM. (however, I am not particularly qualified to comment on the js changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged to make feature freeze. @jloleysens Could you please take a look at this, even if it's merged by the time you get eyes on it?
💔 Build Failed |
Retest |
💔 Build Failed |
💔 Build Failed |
Retest |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, the look good and make sense to me! Retroactive approval from my side.
Summary
This commit adds support to console for Enrich policies. https://www.elastic.co/guide/en/elasticsearch/reference/master/enrich-apis.html
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers