[discuss] Adopt common Service interface #48455
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR demos adopting the
Service
interface and basing thePlugin
interface on it as proposed in #47065 (comment)Currently, this only demos a single Core service using this pattern. Open questions:
stop
required? It's currently optional for Plugin but required for CoreServiceServerType
utility?[skip-ci]
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers