-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security/Spaces - cleanup react warnings #53287
Security/Spaces - cleanup react warnings #53287
Conversation
Pinging @elastic/kibana-security (Team:Security) |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ACK: will review today or tomorrow CET morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
await Promise.resolve(); | ||
|
||
wrapper.update(); | ||
await act(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came across that utility when writing tests for the role management UI. I thought you'd appreciate that change!
…f github.com:mbondyra/kibana into IS-51910_share-lens-change-index-pattern-in-discover * 'IS-51910_share-lens-change-index-pattern-in-discover' of github.com:mbondyra/kibana: [Discover] Remove angular field filter template code (elastic#53513) [APM] Improve table and other panel loading states (elastic#53459) Security/Spaces - cleanup react warnings (elastic#53287) Revert "NP licensing add functional tests (elastic#53002)" (elastic#53577) NP licensing add functional tests (elastic#53002) fix onLicenseInfoChange callback to be called on update (elastic#53559) Document how to extend request handler context (elastic#53271)
Summary
Addresses React warnings in the Spaces and Security plugins. Most changes were test related, with a couple of changes from
componentWillMount
tocomponentDidMount
.There is one outstanding warning thrown when running our test suite, but it is thrown by
FormattedRelative
, which is part of our@kbn/i18n
package as a result of an older version ofreact-intl
. This should be resolved once #38642 is addressed.