[Discover] Remove angular field filter template code #53513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
added
the
release_note:skip
majagrubic
reviewed
Dec 19, 2019
| @@ -1552,7 +1552,6 @@ | |||
| "kbn.discover.fieldChooser.filter.hideMissingFieldsLabel": "隐藏缺失字段", | |||
| "kbn.discover.fieldChooser.filter.indexAndFieldsSectionAriaLabel": "索引和字段", | |||
| "kbn.discover.fieldChooser.filter.popularTitle": "常用", | |||
| "kbn.discover.fieldChooser.filter.resetFiltersButtonLabel": "重置筛选", | |||
There was a problem hiding this comment.
Hm, just thinking about this... this is one thing I omitted in my original PR, mostly because Lens doesn't have it. Should we add this option as well? Definitely not a blocker for this PR, just thinking it might be worth adding a backlog item if needed?
There was a problem hiding this comment.
A backlog item to discuss is a good idea! thx!
majagrubic
approved these changes
Dec 19, 2019
|
🚢 🎉 🎄 |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Dec 19, 2019
kertal
added a commit
that referenced
this pull request
Dec 19, 2019
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 19, 2019
…f github.com:mbondyra/kibana into IS-51910_share-lens-change-index-pattern-in-discover * 'IS-51910_share-lens-change-index-pattern-in-discover' of github.com:mbondyra/kibana: [Discover] Remove angular field filter template code (elastic#53513) [APM] Improve table and other panel loading states (elastic#53459) Security/Spaces - cleanup react warnings (elastic#53287) Revert "NP licensing add functional tests (elastic#53002)" (elastic#53577) NP licensing add functional tests (elastic#53002) fix onLicenseInfoChange callback to be called on update (elastic#53559) Document how to extend request handler context (elastic#53271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🎄 cleanup of unused code in Discover. The field filter template in Angular in the victim. Redundant since #48452
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately