[Reporting] Update some runtime validations #53975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
This PR would be a good time to add string tags for translation in this validation files |
tsullivan
force-pushed
the
reporting/validate-server-host
branch
from
78dca6a to
7bf9f8b
Compare
tsullivan
commented
Jan 7, 2020
| const reportingKibanaHostName = config.get(configKey); | ||
|
|
||
| if (!reportingKibanaHostName && serverHost === '0') { | ||
| // @ts-ignore: No set() method on KibanaConfig, just get() and has() |
There was a problem hiding this comment.
This is brought up as a concern in the Reporting migration issue: #53898
|
ready for review |
tsullivan
commented
Jan 7, 2020
x-pack/legacy/plugins/reporting/server/lib/validate/validate_encryption_key.ts
Show resolved
Hide resolved
joelgriffith
reviewed
Jan 8, 2020
joelgriffith
suggested changes
Jan 8, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jan 9, 2020
* [Reporting] Update some runtime validations * fix unit test * i18n * make warning logging of encryptionKey possible * update snapshot * revert unrelated config change
tsullivan
added a commit
that referenced
this pull request
Jan 9, 2020
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release note: added a self-check for Reporting to prevent an incompatible config from stopping Reporting from working.
server.host: "0"Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] This was checked for keyboard-only and screenreader accessibility