Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor saved object management registry usage #54155

Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
feef34c
Migrate registry to TypeScript
kertal Jan 7, 2020
eb45ab0
Adapt plugins
kertal Jan 7, 2020
139fcfc
Migrate management code
kertal Jan 7, 2020
f1f635f
Adapt VisualizeEmbeddableFactory to use createSavedVisLoader
kertal Jan 8, 2020
49bdf27
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…
kertal Jan 8, 2020
aa6ff7c
Improve VisualizeEmbeddableFactory code
kertal Jan 8, 2020
ebadc49
Migrate SavedObjectLoader services registration to management section
kertal Jan 8, 2020
f721047
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…
kertal Jan 8, 2020
a12e7aa
Replace Angular SavedSearchLoader in transform plugin
kertal Jan 8, 2020
efa7a1d
Add data plugin to transform plugin
kertal Jan 8, 2020
9f693c5
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…
kertal Jan 8, 2020
d45ad30
Fix types in transform plugin
kertal Jan 9, 2020
b2208cc
Merge branch 'master' into kertal-pr-2020-01-07-refactor-saved-object…
elasticmachine Jan 13, 2020
691351d
Address review comments
kertal Jan 15, 2020
22f586e
Merge branch 'kertal-pr-2020-01-07-refactor-saved-object-management-r…
kertal Jan 15, 2020
0bdf4df
Centralize getSavedVisualizations function
kertal Jan 20, 2020
f76aeea
Merge master/fix conflicts
kertal Jan 24, 2020
522c197
Migrate saved_visualizations from visualize to visualizations plugin
kertal Jan 24, 2020
2040176
Fix timelion
kertal Jan 24, 2020
0c7b1ac
Fix management objects _view.js angular rendering
kertal Jan 24, 2020
4eed031
Refactor savedVisualizations to getSavedVisualizationsLoader
kertal Jan 24, 2020
c0067da
Merge upstream/master, fix merge problems
kertal Jan 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix timelion
  • Loading branch information
kertal committed Jan 24, 2020
commit 2040176b23b36b65a623590a33f5667a8564e9b4
3 changes: 2 additions & 1 deletion src/legacy/core_plugins/timelion/public/app.js
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ import '../../data/public/legacy';
import './services/saved_sheet_register';

import rootTemplate from 'plugins/timelion/index.html';
import { createSavedVisLoader } from '../../kibana/public/visualize';
import { createSavedVisLoader, TypesService } from '../../visualizations/public';

require('plugins/timelion/directives/cells/cells');
require('plugins/timelion/directives/fixed_element');
@@ -131,6 +131,7 @@ app.controller('timelion', function(
indexPatterns: npStart.plugins.data.indexPatterns,
chrome: npStart.core.chrome,
overlays: npStart.core.overlays,
visualizationTypes: new TypesService().start(),
});
const timezone = Private(timezoneProvider)();