-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index template] Fix editor should support mappings types #55804
Merged
sebelga
merged 19 commits into
elastic:7.x
from
sebelga:fix/Index-template-editor-should-support-mappings-types
Jan 29, 2020
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0bae3df
Add type metadata to extract mappings definition
sebelga bfc5226
Add "include_type_name" parameter to server API req
sebelga 892afa9
Return mappings inside type if one has been detected
sebelga 7d5def9
Add "include_type_name" req param to client requests
sebelga 92875e4
Move query param to "sendRequest" query object
sebelga de48af4
Forward "include_type_name" api call to ES request call
sebelga 028bb28
Fix API integration test
sebelga ba056e1
Refactor client integration tests: call registerTestBed() from setup
sebelga 001442c
Add strictness to mappings validator to not allow unknown parameters
sebelga a97722a
Add test to detect custom type with mappings configuration name
sebelga b9ad4ac
Use "dynamic" in test type detection instead of "_source"
sebelga 1d2a508
Detect mappings type in LoadMappingsProvider
sebelga 3493e7d
Add client integration tests for LoadMappignsProvider
sebelga 0045d0d
Merge remote-tracking branch 'upstream/7.x' into fix/Index-template-e…
sebelga df98c23
Refactor: change helper func to "doMappingsHaveType"
sebelga 9f281c2
Fix TS issues
sebelga 0f5e083
Merge remote-tracking branch 'upstream/7.x' into fix/Index-template-e…
sebelga 8fa68b5
Address CR changes
sebelga 1cbaf4d
Remove comment about io-ts lib
sebelga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think the name
doMappingsHaveType
or evenisTypedMappings
would be more grammatically correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure 😊