Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] Adds ability to infer the newsfeed.enabled setting (#56236) #56265

Merged
merged 1 commit into from
Jan 29, 2020

Commits on Jan 29, 2020

  1. [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236

    )
    
    * Always return a contract from the newsfeed plugin
    
    Without a contract, dependent plugins have no way of knowing whether the
    plugin is enabled or not as the contract will always be undefined.
    
    * Export newsfeed contract types from public index
    
    So that dependent plugins can use them.
    
    * Declare newsfeed as an optional dependency of SIEM
    
    We're going to use the availability of the newsfeed plugin as part of our
    determination for whether or not to show the security newsfeed. If users
    set `newsfeed.enabled: false`, the plugin will be unavailable and the
    security feed will not be shown.
    
    * Respect global newsfeed.enabled config in Security newsfeed
    
    The presence of the newsfeed plugin means that newsfeed.enabled is true.
    If both that and our local setting are true, we will show the Security
    feed.
    
    * Prefer object type over empty interface
    
    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
    rylnd and elasticmachine committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    88b458c View commit details
    Browse the repository at this point in the history