Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suid bit from Docker image files to mitigate Stack Clash #56826

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

mieciu
Copy link
Contributor

@mieciu mieciu commented Feb 5, 2020

Summary

This PR removes suid bit from binaries of Kibana Docker image in order to mitigate "Stack Clash" vulnerability (ref: https://blog.qualys.com/securitylabs/2017/06/19/the-stack-clash). As the image is based on CentOS, there are few of those:

$ docker run --user=0 --rm -i -t docker.elastic.co/kibana/kibana:7.5.0 find / -xdev -perm -4000
/usr/bin/passwd
/usr/bin/umount
/usr/bin/chfn
/usr/bin/su
/usr/bin/chsh
/usr/bin/newgrp
/usr/bin/gpasswd
/usr/bin/chage
/usr/bin/mount
/usr/sbin/unix_chkpwd
/usr/sbin/pam_timestamp_check
/usr/libexec/dbus-1/dbus-daemon-launch-helper

Related: #52450

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley added the release_note:skip Skip the PR/issue when compiling release notes label Feb 5, 2020
@jbudz jbudz merged commit 90a9dc2 into elastic:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Build Packaging release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants