-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM][CASE] ServiceNow executor #58894
Conversation
Pinging @elastic/siem (Team:SIEM) |
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
08482fa
to
42cff02
Compare
@elasticmachine merge upstream |
Adding to the README would be great. If there's a README description I will take care of the asciidoc conversion when the time comes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mikecote @YulNaumenko Thanks a lot for your review. I did a few small changes to the logic of the executor, especially how we treat comments. @mikecote I made the changes you requested. |
68f9b6c
to
da2edb9
Compare
da2edb9
to
42110b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 just one comment about the README.
* Refactor structure * Init ServiceNow class * Add constants * Add configuration scheme * Refactor configuration schema * Refactor parameters schema * Create new types * Add supported source fields * Create helpers * Create ServiceNow lib * Push incident * Declare private methods * Create UpdateIncident type * Create updateIncident method * Create executor actions * Refactor response * Test helpers * Remove unnecessary validation * Fix validation errors * Throw error for unsupported actions * Create mock incident * Test executor * Test ServiceNow lib * Convert to camelCase * Remove caller_id * Refactor helpers * Refactor schema * Remove executorAction * Test action handlers * Refactor tests * Create and update comments * Remove closure option & change attribute name * Fix tests * Change lib structure * Validate empty mapping * Fix functional tests * Fix type * Change API to only add comments through incident's API * Add instruction to README * Change API version * Test * Test simulator * Fix version on tests * Remove SIEM reference in README
* Refactor structure * Init ServiceNow class * Add constants * Add configuration scheme * Refactor configuration schema * Refactor parameters schema * Create new types * Add supported source fields * Create helpers * Create ServiceNow lib * Push incident * Declare private methods * Create UpdateIncident type * Create updateIncident method * Create executor actions * Refactor response * Test helpers * Remove unnecessary validation * Fix validation errors * Throw error for unsupported actions * Create mock incident * Test executor * Test ServiceNow lib * Convert to camelCase * Remove caller_id * Refactor helpers * Refactor schema * Remove executorAction * Test action handlers * Refactor tests * Create and update comments * Remove closure option & change attribute name * Fix tests * Change lib structure * Validate empty mapping * Fix functional tests * Fix type * Change API to only add comments through incident's API * Add instruction to README * Change API version * Test * Test simulator * Fix version on tests * Remove SIEM reference in README
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Summary
This PR implements a ServiceNow connector where one can create or update incidents to ServiceNow. The action is needed for the Case Management System.
Usage
Create action:
Create a ServiceNow action. See README for more information about the parameters.
Endpoint:
api/action
Method:
POST
Payload:
Response:
Create an incident:
Create an incident to ServiceNow. When the
incidentId
attribute is not inparams
the executor will create the incident.Endpoint:
api/action/<action_id>/_execute
Method:
POST
Payload:
Response
Update an incident:
Update an incident to ServiceNow. When the
incidentId
attribute is inparams
the executor will update the incident.Endpoint:
api/action/<action_id>/_execute
Method:
POST
Payload:
Response
Checklist
Delete any items that are not applicable to this PR.
For maintainers