[SIEM] Adds 'Close one signal' Cypress test #60064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
MadameSheema
force-pushed
the
close-one-signal
branch
from
77d94d7 to
4f00cfc
Compare
MadameSheema
force-pushed
the
close-one-signal
branch
from
bc22976 to
5fe04fc
Compare
MadameSheema
requested review from
FrankHassanabad,
rylnd,
spong,
patrykkopycinski,
dhurley14 and
yctercero
MadameSheema
added
release_note:skip
FrankHassanabad
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Looks like it does what it describes. Appreciate the small concentrated pull requests. Makes reviewing things very quick and easy. It also makes it really nice to upgrade my branches these are merged and I will know if I have a failure where to look really quickly.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 16, 2020
* master: [Step 1][App Arch] Saved object migrations from kibana plugin to new platform (elastic#59044) adds new test (elastic#60064) [Uptime] Index Status API to Rest (elastic#59657)
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 16, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 16, 2020
* master: (40 commits) skips 'config_open.ts' files from linter check (elastic#60248) [Searchprofiler] Spacing between rendered shards (elastic#60238) Add UiSettings validation & Kibana default route redirection (elastic#59694) [SIEM][CASE] Change configuration button (elastic#60229) [Step 1][App Arch] Saved object migrations from kibana plugin to new platform (elastic#59044) adds new test (elastic#60064) [Uptime] Index Status API to Rest (elastic#59657) [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950) [NP] Graph migration (elastic#59409) [ML] Clone analytics job (elastic#59791) Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202) Handle improperly defined Watcher Logging Action text parameter. (elastic#60169) Move select range trigger to uiActions (elastic#60168) [SIEM][CASES] Configure cases: Final (elastic#59358) Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153) [siem/cypress] update junit filename to be picked up by runbld (elastic#60156) OSS logic added to test environment (elastic#60134) Move canvas setup into app mount (elastic#59926) enable triggers_actions_ui plugin by default (elastic#60137) Expose Elasticsearch from start and deprecate from setup (elastic#59886) ...
MadameSheema
added a commit
that referenced
this pull request
Mar 16, 2020
spalger
added a commit
that referenced
this pull request
Mar 16, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...
MadameSheema
added a commit
that referenced
this pull request
Mar 17, 2020
This reverts commit a946adb.
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 17, 2020
This reverts commit 4a8fd0a.
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 17, 2020
…selected' test again (elastic#60380) * Revert "Revert "adds new test (elastic#60064)"" This reverts commit 4a8fd0a. * waits for having 25 signals displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are adding a Cypress test to check that only one signal is closed when more than one are selected.
In order to test it these actions are performed:
Note that to make the test pass it is expected to have only opened signals. When running the tests in CI mode, this is achieved because it loads using es_arhiver a set of data that only have open signals.