[Logs UI] Correctly update the expanded log rate table rows

[weltenwort]

Summary

This ensures that the content of the expanded rows in the log rate table reflect the most recent results.

Fixes #60300

Testing

See #60300 for reproduction of the fixed issue.

[elasticmachine]

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

[jasonrhodes]

Looking at this today, good catch 👍

[jasonrhodes]

In looking at this, I'm not sure if it's working as expected and I'm just missing something, or if there's a bug.

This is when the date picker is set to "Today" (notice the Mar 18 rows in both expanded sets)

Then, when switching to "Last 24 hours" (notice the first expanded set changes its rows to Mar 17):

This happens when I switch back and forth between these date ranges. (Today is March 18 as I am doing this test, so I'm expecting the first image and not the second.)

Looks like "Today" sends a request to log_entry_categories with timeRange: {startTime: 1584504000000, endTime: 1584590399999} and "Last 24 hours" sends that request with timeRange: {startTime: 1584477654684, endTime: 1584564054685}

I'm wondering if this has some kind of time zone related bug?

I'm also getting this in the console:

Warning: Failed prop type: The prop `initialSelectedTab.name` is marked as required in `EuiTabbedContent`, but its value is `undefined`.

[jasonrhodes]

I suppose it's important to also add: the examples are definitely updating when I update the time range :) 👍

[jasonrhodes]

@elasticmachine merge upstream

[weltenwort]

Thanks for the review, @jasonrhodes. This PR changes the log rate tab while your screenshots show the log categories tab.

That aside, could you elaborate in which way these timestamps violate your expectations? Both seem to span 24 hours, with one aligned at your local day boundaries (today) while the other is aligned to your local time (now-24h to now).

The error message about the missing tab property in the datepicker seems to be a bug in EUI, which can be observed everywhere in Kibana and has to be resolved upstream. I'll open an issue or PR there.

[weltenwort]

@elasticmachine merge upstream

[jasonrhodes]

@weltenwort sorry, I'll check Log Rate and report back.

As for the screenshots, if I have results from today, I'd expect them to show up in "Today" and in "Last 24 hours", and I can't easily explain why they wouldn't.

[weltenwort]

if I have results from today, I'd expect them to show up in "Today" and in "Last 24 hours"

"Last 24 hours" also covers parts of yesterday most of the time, so assuming the time of testing was before 16:49:57 on March 18 the first screenshot seems valid. I guess you're surprised that the five samples are not the newest ones in respect to the time range?

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 679fe42

History

• 💔 Build #34338 failed 6660af2
• 💚 Build #33573 succeeded 58b61bd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jasonrhodes]

I guess you're surprised that the five samples are not the newest ones in respect to the time range?

Yes, exactly. How are those chosen?

[weltenwort]

right now it's ascending by @timestamp

[jasonrhodes]

Interesting so it's the earliest ones in the given window. I think I expect the most recent ones but I have no idea if I'm representative there. Anyway that's not part of this PR though. :)

[jasonrhodes]

Fix for the log rate tab LGTM.