[SIEM][CASE] Fix aria-labels and translations #61670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
26 tasks
cnasikas
force-pushed
the
fix_i18n_labels
branch
2 times, most recently
from
461fe85 to
708c369
Compare
| <Link | ||
| className="siemLinkIcon" | ||
| color={color} | ||
| disabled={disabled} | ||
| href={href} | ||
| iconSide={iconSide} | ||
| onClick={onClick} | ||
| aria-label={ariaLabel ?? children} |
There was a problem hiding this comment.
why do we use children here?
There was a problem hiding this comment.
Because the aria-label is optional and the children is a string. Because the component is used all over the place I did not want to break anything. Do you believe we should use something else? Or maybe do not implement the aria-label on Link component at all?
There was a problem hiding this comment.
Maybe we should rename the props children to something else so it is less confusing
There was a problem hiding this comment.
This prop is the React's prop children. If I change it I have to change the usage (<LinkIcon>{somthing_here_as_children}</LinkIcon>) all over the place.
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
cnasikas
force-pushed
the
fix_i18n_labels
branch
from
ec2480f to
708c369
Compare
cnasikas
force-pushed
the
fix_i18n_labels
branch
from
708c369 to
85b9e51
Compare
patrykkopycinski
approved these changes
Mar 31, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Mar 31, 2020
* Fix aria-labels and translations * Fix conflicts and bugs
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Mar 31, 2020
* Fix aria-labels and translations * Fix conflicts and bugs
cnasikas
added a commit
that referenced
this pull request
Mar 31, 2020
cnasikas
added a commit
that referenced
this pull request
Mar 31, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 31, 2020
* upstream/master: (69 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 1, 2020
* master: (64 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
aria-labelswhen appropriate and fix translations (#61092).Checklist
Delete any items that are not applicable to this PR.
For maintainers