[ML] DF Analytics results table: use index pattern field format if one exists #61709

alvarezmelissa87 · 2020-03-27T22:55:08Z

Summary

Updates classification/regression/outlier detections result views to use destination index pattern (if exists) or source index pattern (if dest doesn't exist) to get field caps and field format data.

If format data exists for that field, use that format. Otherwise use existing format (human readable dates, etc).

Before:

After:

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

elasticmachine · 2020-03-27T22:57:14Z

Pinging @elastic/ml-ui (:ml)

peteharverson

Tested and LGTM

jgowdyelastic

Added a few nits, nothing important. LGTM

jgowdyelastic · 2020-03-30T15:26:18Z

x-pack/plugins/ml/public/application/data_frame_analytics/common/fields.ts

+      : [];
+
+  allFields.push(...fields);
+  // @ts-ignore


it would be good to have a comment explaining what is being ignored on this line.

jgowdyelastic · 2020-03-30T15:35:23Z

...nalytics/pages/analytics_exploration/components/classification_exploration/results_table.tsx

+              } else {
+                column.render = (d: any) => {
+                  if (d !== undefined) {
+                    return formatHumanReadableDateTimeSeconds(moment(d).unix() * 1000);


nit, moment's valueOf() is already in milliseconds

jgowdyelastic · 2020-03-30T15:37:36Z

...ytics/pages/analytics_exploration/components/exploration_data_grid/exploration_data_grid.tsx

@@ -12,6 +12,10 @@ import { EuiDataGrid, EuiDataGridPaginationProps, EuiDataGridSorting } from '@el

 import { euiDataGridStyle, euiDataGridToolbarSettings } from '../../../../common';

+import { mlFieldFormatService } from '../../../../../services/field_format_service';
+
+import { IndexPattern } from '../../../../../../../../../../src/plugins/data/public';


i think this path can just be src/plugins/data/public

alvarezmelissa87 · 2020-03-30T21:51:26Z

retest

alvarezmelissa87 · 2020-03-31T02:24:07Z

retest

kibanamachine · 2020-03-31T14:54:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 49dd643

History

💔 Build #37390 failed cdf1f4b6e31fbeb24f774f24a0b79a83d91aaf5a
💔 Build #37323 failed cdf1f4b6e31fbeb24f774f24a0b79a83d91aaf5a
💔 Build #37265 failed cdf1f4b6e31fbeb24f774f24a0b79a83d91aaf5a
💚 Build #37130 succeeded af06025dd7dcfa05dfe52f4366eb9c563fdbacf8
💔 Build #36952 failed 2fb1dd829247682cee52d7f51be2df4892df0377

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…e exists (elastic#61709) * classification: use index field format in results table * regression: use index field format in results table * outlier: use index field format in results table * update types * add destIndex specific fields when using sourceIndex for fields

…e exists (#61709) (#61989) * classification: use index field format in results table * regression: use index field format in results table * outlier: use index field format in results table * update types * add destIndex specific fields when using sourceIndex for fields

…e exists (#61709) (#61990) * classification: use index field format in results table * regression: use index field format in results table * outlier: use index field format in results table * update types * add destIndex specific fields when using sourceIndex for fields

* upstream/master: (69 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...

* master: (64 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...

alvarezmelissa87 requested a review from a team as a code owner March 27, 2020 22:55

alvarezmelissa87 self-assigned this Mar 27, 2020

alvarezmelissa87 added :ml Feature:Data Frame Analytics ML data frame analytics features release_note:fix labels Mar 27, 2020

alvarezmelissa87 added v7.7.0 v8.0.0 labels Mar 27, 2020

alvarezmelissa87 requested review from peteharverson, jgowdyelastic and darnautov March 30, 2020 13:12

alvarezmelissa87 force-pushed the ml-df-analytics-field-format branch from 2fb1dd8 to af06025 Compare March 30, 2020 13:50

peteharverson approved these changes Mar 30, 2020

View reviewed changes

jgowdyelastic approved these changes Mar 30, 2020

View reviewed changes

alvarezmelissa87 force-pushed the ml-df-analytics-field-format branch from af06025 to cdf1f4b Compare March 30, 2020 18:36

alvarezmelissa87 added 5 commits March 31, 2020 09:08

classification: use index field format in results table

57a76c5

regression: use index field format in results table

cab1602

outlier: use index field format in results table

174b75f

update types

b05bda3

add destIndex specific fields when using sourceIndex for fields

49dd643

alvarezmelissa87 force-pushed the ml-df-analytics-field-format branch from cdf1f4b to 49dd643 Compare March 31, 2020 13:09

alvarezmelissa87 merged commit 069439a into elastic:master Mar 31, 2020

alvarezmelissa87 mentioned this pull request Mar 31, 2020

[7.x] [ML] DF Analytics results table: use index pattern field format if one exists (#61709) #61989

Merged

alvarezmelissa87 mentioned this pull request Mar 31, 2020

[7.7] [ML] DF Analytics results table: use index pattern field format if one exists (#61709) #61990

Merged

alvarezmelissa87 deleted the ml-df-analytics-field-format branch March 31, 2020 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] DF Analytics results table: use index pattern field format if one exists #61709

[ML] DF Analytics results table: use index pattern field format if one exists #61709

alvarezmelissa87 commented Mar 27, 2020 •

edited

Loading

elasticmachine commented Mar 27, 2020

peteharverson left a comment

jgowdyelastic left a comment

jgowdyelastic Mar 30, 2020

jgowdyelastic Mar 30, 2020

jgowdyelastic Mar 30, 2020

alvarezmelissa87 commented Mar 30, 2020

alvarezmelissa87 commented Mar 31, 2020

kibanamachine commented Mar 31, 2020

[ML] DF Analytics results table: use index pattern field format if one exists #61709

[ML] DF Analytics results table: use index pattern field format if one exists #61709

Conversation

alvarezmelissa87 commented Mar 27, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Mar 27, 2020

peteharverson left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

jgowdyelastic Mar 30, 2020

Choose a reason for hiding this comment

jgowdyelastic Mar 30, 2020

Choose a reason for hiding this comment

jgowdyelastic Mar 30, 2020

Choose a reason for hiding this comment

alvarezmelissa87 commented Mar 30, 2020

alvarezmelissa87 commented Mar 31, 2020

kibanamachine commented Mar 31, 2020

💚 Build Succeeded

History

alvarezmelissa87 commented Mar 27, 2020 •

edited

Loading