[SIEM] 7.7. NP Cleanup #61713
Merged
[SIEM] 7.7. NP Cleanup #61713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylnd
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
These were migrated to NP in a previous PR.
If a plugin does not have siem enabled, they won't get our client. While it seems unlikely to be in a situation where our routes are being hit but our client is unavailable, we will return a 404 in that case, similar to the unavailability of actions/alerting. This also removes some redundant checks on action/alerting clients.
In general, we use optional chaining to ignore any intermediate null values, and defer checks to our actual dependencies, e.g. alertsClient or siemClient.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Mar 30, 2020
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Mar 30, 2020
* Remove unused legacy services These were migrated to NP in a previous PR. * Remove unused legacy request types * Type our siem client as optional If a plugin does not have siem enabled, they won't get our client. While it seems unlikely to be in a situation where our routes are being hit but our client is unavailable, we will return a 404 in that case, similar to the unavailability of actions/alerting. This also removes some redundant checks on action/alerting clients. * Remove more redundant dependency checks In general, we use optional chaining to ignore any intermediate null values, and defer checks to our actual dependencies, e.g. alertsClient or siemClient.
rylnd
added a commit
that referenced
this pull request
Mar 31, 2020
* Remove unused legacy services These were migrated to NP in a previous PR. * Remove unused legacy request types * Type our siem client as optional If a plugin does not have siem enabled, they won't get our client. While it seems unlikely to be in a situation where our routes are being hit but our client is unavailable, we will return a 404 in that case, similar to the unavailability of actions/alerting. This also removes some redundant checks on action/alerting clients. * Remove more redundant dependency checks In general, we use optional chaining to ignore any intermediate null values, and defer checks to our actual dependencies, e.g. alertsClient or siemClient. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rylnd
added a commit
that referenced
this pull request
Mar 31, 2020
* Remove unused legacy services These were migrated to NP in a previous PR. * Remove unused legacy request types * Type our siem client as optional If a plugin does not have siem enabled, they won't get our client. While it seems unlikely to be in a situation where our routes are being hit but our client is unavailable, we will return a 404 in that case, similar to the unavailability of actions/alerting. This also removes some redundant checks on action/alerting clients. * Remove more redundant dependency checks In general, we use optional chaining to ignore any intermediate null values, and defer checks to our actual dependencies, e.g. alertsClient or siemClient. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few housekeeping tasks following NP changes made since 7.6.
siemClientas optional for other plugins (as siem may be disabled)For maintainers