Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Settings: Increase number of items that can be paged in calendars and filters lists #61842

Merged
merged 3 commits into from
Mar 31, 2020
Merged

[ML] Settings: Increase number of items that can be paged in calendars and filters lists #61842

merged 3 commits into from
Mar 31, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Mar 30, 2020 •
edited
Loading

Summary

Fixes #61288
Sets size limit to 1000 for /filters and /calendars routes.

We can now see all 11 filters:

image

Checklist

@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner March 30, 2020 16:00
@alvarezmelissa87 alvarezmelissa87 self-assigned this Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic reviewed Mar 30, 2020
View reviewed changes
x-pack/plugins/ml/server/client/elasticsearch_ml.ts Outdated
@@ -671,7 +671,7 @@ export const elasticsearchJsPlugin = (Client: any, config: any, components: any)
},
method: 'DELETE',
});

// Filters default size limit is 10 so explicitly set to 1000 for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 10 correct in this comment?

Copy link
Contributor

@peteharverson peteharverson Mar 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it has now been fixed on the back-end to be 100.
Edit to say

// Currently the endpoint uses a default size of 100 unless a size is supplied. So until paging is supported in the UI, explicitly supply a size of 1000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'tis

peteharverson
peteharverson approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggested to the comments. Otherwise LGTM.

x-pack/plugins/ml/server/client/elasticsearch_ml.ts Outdated
@@ -514,7 +514,7 @@ export const elasticsearchJsPlugin = (Client: any, config: any, components: any)
needBody: true,
method: 'POST',
});

// Calendars default size limit is 100 so explicitly set to 1000 for now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit to say

// Currently the endpoint uses a default size of 100 unless a size is supplied. So until paging is supported in the UI, explicitly supply a size of 1000

@alvarezmelissa87
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #37269 failed 42bb6daffd6988f511fd9871854475796ac22a27
  • 💔 Build #37253 failed dc91911d8820990d8fadfd68eafd8c3bc7fba125
  • 💔 Build #37199 failed caea4f851f63ae3c05da4ace8546ae432a79a4d6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jgowdyelastic
jgowdyelastic approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit f1866b3 into elastic:master Mar 31, 2020
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Mar 31, 2020
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 31, 2020
@alvarezmelissa87
[ML] Settings: Increase number of items that can be paged in calendar…
e8fe720 
…s and filters lists (elastic#61842)

* set size limit to 1000 for calendars/filters get routes

* update comment

* update default size comment
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 31, 2020
@alvarezmelissa87
[ML] Settings: Increase number of items that can be paged in calendar…
bcd418a 
…s and filters lists (elastic#61842)

* set size limit to 1000 for calendars/filters get routes

* update comment

* update default size comment
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Mar 31, 2020
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-settings-add-size branch March 31, 2020 13:29
alvarezmelissa87 added a commit that referenced this pull request Mar 31, 2020
@alvarezmelissa87
[ML] Settings: Increase number of items that can be paged in calendar…
a407d73 
…s and filters lists (#61842) (#61969)

* set size limit to 1000 for calendars/filters get routes

* update comment

* update default size comment
alvarezmelissa87 added a commit that referenced this pull request Mar 31, 2020
@alvarezmelissa87
[ML] Settings: Increase number of items that can be paged in calendar…
813f42a 
…s and filters lists (#61842) (#61970)

* set size limit to 1000 for calendars/filters get routes

* update comment

* update default size comment
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 31, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerting/start-trial
2d80df2 
* upstream/master: (69 commits)
  Adding PagerDuty icon to connectors cards (elastic#60805)
  Fix drag and drop flakiness (elastic#61993)
  Grok debugger migration (elastic#60658)
  Endpoint: Fix resolver SVG position issue (elastic#61886)
  [SIEM] version 7.7 rule import (elastic#61903)
  Added styles to make combobox list items wider for alerting flyout (elastic#61894)
  [UA] Tight worker loop can cause high CPU usage (elastic#60950)
  [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709)
  [ML] Catching unknown index pattern errors (elastic#61935)
  [Discover] Deangularize and euificate sidebar  (elastic#47559)
  Endpoint: Add ts-node dev dependency (elastic#61884)
  Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901)
  [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649)
  Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171)
  [Maps] Explicitly pass fetch function to ems-client (elastic#61846)
  [SIEM][CASE] Fix aria-labels and translations (elastic#61670)
  [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842)
  [EPM] update epm filepath route (elastic#61910)
  APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732)
  [Logs UI] Log stream row rendering (elastic#60773)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 1, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
a0e1dcd 
* master: (64 commits)
  Adding PagerDuty icon to connectors cards (elastic#60805)
  Fix drag and drop flakiness (elastic#61993)
  Grok debugger migration (elastic#60658)
  Endpoint: Fix resolver SVG position issue (elastic#61886)
  [SIEM] version 7.7 rule import (elastic#61903)
  Added styles to make combobox list items wider for alerting flyout (elastic#61894)
  [UA] Tight worker loop can cause high CPU usage (elastic#60950)
  [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709)
  [ML] Catching unknown index pattern errors (elastic#61935)
  [Discover] Deangularize and euificate sidebar  (elastic#47559)
  Endpoint: Add ts-node dev dependency (elastic#61884)
  Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901)
  [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649)
  Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171)
  [Maps] Explicitly pass fetch function to ems-client (elastic#61846)
  [SIEM][CASE] Fix aria-labels and translations (elastic#61670)
  [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842)
  [EPM] update epm filepath route (elastic#61910)
  APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732)
  [Logs UI] Log stream row rendering (elastic#60773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Increase number of items that can be paged in calendars and filters lists
5 participants
@alvarezmelissa87 @elasticmachine @kibanamachine @peteharverson @jgowdyelastic