-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mount ui/new_platform applications in same div structure as Core #63930
Mount ui/new_platform applications in same div structure as Core #63930
Conversation
Pinging @elastic/kibana-platform (Team:Platform) |
@crob611 I'm guessing this is failing for the same reason that you were having troubling migrating Canvas over? |
Yes, this "breaks" the rendering of Canvas through Should the kibana theme be updated to account for this new rendering structure? (I'm not sure where that theme comes from). Should the |
I'm not sure what theme you're talking about? |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that it changes legacy to match KP.
I don't see any reason why this should be causing the smoke test to fail. I can't see any selectors that should be affected by this, but I can dig in if I need to.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
2cde2d0
to
b73231a
Compare
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/_async_dashboard·ts.dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2"Standard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
Summary
This ensures that legacy apps that utilize the
ui/new_platform
bridge are mounted in the same DOM structure as true KP apps.Dev Docs
Applications that are mounted via the
core.application.register
interface from the legacyui/new_platform
module are now mounted inside a newdiv
inside of the<div class="application />
node rather than directly inside that node. This makes the legacy bridge consistent with how true KP applications are mounted.Checklist
Delete any items that are not applicable to this PR.
For maintainers