-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set readFromDocValues to false for geo_shape fields #64014
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
...r/index_patterns/fetcher/lib/field_capabilities/should_read_field_from_doc_values.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { shouldReadFieldFromDocValues } from './should_read_field_from_doc_values'; | ||
|
||
describe('shouldReadFieldFromDocValues', () => { | ||
test('should read field from doc values for aggregatable "number" field', async () => { | ||
expect(shouldReadFieldFromDocValues(true, 'number')).toBe(true); | ||
}); | ||
|
||
test('should not read field from doc values for non-aggregatable "number "field', async () => { | ||
expect(shouldReadFieldFromDocValues(false, 'number')).toBe(false); | ||
}); | ||
|
||
test('should not read field from doc values for "text" field', async () => { | ||
expect(shouldReadFieldFromDocValues(true, 'text')).toBe(false); | ||
}); | ||
|
||
test('should not read field from doc values for "geo_shape" field', async () => { | ||
expect(shouldReadFieldFromDocValues(true, 'geo_shape')).toBe(false); | ||
}); | ||
|
||
test('should not read field from doc values for underscore field', async () => { | ||
expect(shouldReadFieldFromDocValues(true, '_source')).toBe(false); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so the two cases here are:
readFromDocValues
is false on geo_shape fields because it wasn't previously supportedreadFromDocValues
is false because of the logic change in the index pattern serviceIs that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct.
For old index pattern
readFromDocValues
was false because geo_shape did not support docvalues and aggregations.For new index patterns
readFromDocValues
should be false even though geo_shape has docvalues support and can support aggregations. This is do to changed in Elasticsearch 7.8 adding docvalue support to geo_shape fieldsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is removing a quick fix just merged (into master and 7.8) a few days ago. We decided a better fix is at the index pattern level.