Use brotli compression for some KP assets #64367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
joshdover
force-pushed
the
np/brotli
branch
7 times, most recently
from
b709690
to
4947ce3
Compare
joshdover
added
release_note:enhancement
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
tylersmalley
approved these changes
May 1, 2020
mshustov
approved these changes
May 4, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
May 4, 2020
# Conflicts: # packages/kbn-ui-shared-deps/package.json # renovate.json5 # src/dev/renovate/package_groups.ts
joshdover
added a commit
that referenced
this pull request
May 4, 2020
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds new compressed outputs to @kbn/optimizer and @kbn/shared-ui-deps along with code in our bundle serving logic to select the best/correct compression based on the client's preferences specified in the
Accept-Encodingheader. Brotli compression decreases bytes sent across the network by ~30%.Note that browsers will only include
brin theAccept-Encodingheader when connecting over HTTPS.I have spoken to the Cloud Networking team and they do not anticipate any problems with their load balancers processing brotli-compressed responses. Unfortunately we won't be able to test this until this makes into a nightly snapshot which we can easily deploy to Cloud staging. There are integration tests ready to go in this PR for this test case.
Release Notes
Kibana instances served over HTTPS will now benefit from improved asset compression on most JS & CSS files. This decreases network transfer by about 30% in most scenarios.
Checklist
Delete any items that are not applicable to this PR.
For maintainers