Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Migrate server-side usage collector #67233

Merged
merged 5 commits into from
May 27, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented May 22, 2020

Summary

Part of Reporting server-side migration from Legacy to Kibana Platform: #53898

This PR replaces a Legacy dependency called xpack_main from the Reporting usage collector and replaces it by getting license info from the Licensing plugin in Kibana Platform.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan force-pushed the reporting/migrate-usage-collector branch from be8c4a3 to c2f8aa4 Compare May 26, 2020 16:41
@elastic elastic deleted a comment from kibanamachine May 26, 2020
@tsullivan tsullivan mentioned this pull request May 26, 2020
19 tasks
@tsullivan tsullivan requested a review from joelgriffith May 26, 2020 20:28
@tsullivan tsullivan marked this pull request as ready for review May 26, 2020 20:28
const getLicense = async () => {
return await licensing.license$
.pipe(
map(({ isAvailable, type }) => ({
Copy link
Member Author

@tsullivan tsullivan May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FeaturesAvailable type being implemented here carries over the shape of the data from the Legacy xpack_main. This is done to avoid needing extra changes for underlying code.

@tsullivan tsullivan changed the title [Reporting] Migrate server/usage [Reporting] Migrate server-side usage collector May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label May 26, 2020
@tsullivan tsullivan requested a review from pgayvallet May 26, 2020 20:46
Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger
Copy link
Contributor

spalger commented May 26, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented May 26, 2020

(jenkins upgrade required killing all jobs)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 77ba703 into elastic:master May 27, 2020
tsullivan added a commit to tsullivan/kibana that referenced this pull request May 27, 2020
* [Reporting] Migrate server/usage

* fix import

* polish

* prefer inferring return type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit that referenced this pull request May 27, 2020
* [Reporting] Migrate server/usage

* fix import

* polish

* prefer inferring return type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@tsullivan tsullivan deleted the reporting/migrate-usage-collector branch June 25, 2020 18:09
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants