-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Allow custom label for fields via index pattern field management #70039
[Discover] Allow custom label for fields via index pattern field management #70039
Conversation
…-25-index-pattern-field-label
…-25-index-pattern-field-label
…-25-index-pattern-field-label
…-25-index-pattern-field-label
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
…ement (elastic#70039) Co-authored-by: Matt Kime <matt@mattki.me>
* master: (51 commits) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) skip flaky suite (elastic#77279) [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923) [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544) [ML] Add UI test for feature importance features (elastic#82677) [Maps] Improve icons for all layer types (elastic#83503) Replace experimental badge with Beta (elastic#83468) [Fleet][EPM] Unified install and archive (elastic#83384) Move src/legacy/server/keystore to src/cli (elastic#83483) Used SO for saving the API key IDs that should be deleted (elastic#82211) [Uptime] Mock implementation to account for math flakiness test (elastic#83535) [Workplace Search] Enable check for org context based on URL (elastic#83487) [App Search] Added all Document related routes and logic (elastic#83324) [Alerting UI] Fix console error when setting connector params (elastic#83333) [Discover] Allow custom name for fields via index pattern field management (elastic#70039) [Uptime] Fix monitor list down histogram (elastic#83411) remove headers timeout hack, rely on nodejs timeouts (elastic#83419) [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151) [Lens] Color in dimension trigger (elastic#76871) ...
💔 Build Failed
Failed CI Steps
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts.discover feature controls discover feature controls security "before all" hook in "discover feature controls security"Standard Out
Stack Trace
X-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts.Dashboard Edit Panel "before all" hook for " A11y test on dashboard edit panel menu options"Standard Out
Stack Trace
X-Pack API Integration Tests (Security Basic).x-pack/test/api_integration/apis/security/index_fields·ts.security (basic license) Index Fields "before all" hook in "Index Fields"Standard Out
Stack Trace
and 9 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@ranitg I'm seeing the custom labels in the tooltips. I tried on both Lens and an aggregation-based Line chart. But I created those visualizations using the custom label. Did you create the visualization using the original field name? |
Thanks |
1.Yes the source is still the raw source as returned by ES, that has no idea about those field names, and thus will show them with their original field name. That's intended behavior for now. Though we could optentially open an issue once we switch to usage of the
|
@timroes for sure, will create one |
Summary
UPDATE⚠️ : custom name was renamed to custom label with #83717
This PR enables to add a custom name to a field in index pattern management, and implements its usage in Discover (And also works in Visualize + Lens). This is especially convenient to display long field names in much shorter versions.
Before:
Configuration:
You can configure a custom name in our index pattern management
After:
Part of #69908
Checklist
Delete any items that are not applicable to this PR.
For maintainers