-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Add telemetry for data plugin search service #70677
Conversation
…-side-search-strategy
…-side-search-strategy
…-side-search-strategy
delete search explorer
…om/kibana into search/server-side-search-strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
miscellaneous assets size
page load bundle size
History
To update your PR or re-run it, just comment with: |
* [search] Refactor the way search strategies are registered/retrieved on the server * Fix types and tests and update docs * Fix failing test * Fix build of example plugin * Fix functional test * Make server strategies sync * Move strategy name into options * docs * Remove FE strategies * TypeScript of hell delete search explorer * Fix search interceptor OSS tests * typos * test cleanup * Update search interceptor tests and abort utils * [Search] Add telemetry for data plugin search service * Add tracking of average query time * Add tests and rename to collectors * Fix TS * Fixed interceptor jest tests * Add to kibana json * docs * Properly use observables rather than only during setup * Update or create * Swallow version conflict errors Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: [APM] Add error rates to Service Map popovers (elastic#69520) [Security Solution][Detection Engine] - Update exceptions logic (elastic#71512) [Security Solution] Full screen timeline, Collapse event (elastic#71786) [Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist (elastic#71807) [Detection Rules] Add 7.9 rules (elastic#71808) [Search] Add telemetry for data plugin search service (elastic#70677) Add @elastic/safer-lodash-set as an alternative to lodash.set (elastic#67452) [tests] Temporarily skipped to promote snapshot
* [search] Refactor the way search strategies are registered/retrieved on the server * Fix types and tests and update docs * Fix failing test * Fix build of example plugin * Fix functional test * Make server strategies sync * Move strategy name into options * docs * Remove FE strategies * TypeScript of hell delete search explorer * Fix search interceptor OSS tests * typos * test cleanup * Update search interceptor tests and abort utils * [Search] Add telemetry for data plugin search service * Add tracking of average query time * Add tests and rename to collectors * Fix TS * Fixed interceptor jest tests * Add to kibana json * docs * Properly use observables rather than only during setup * Update or create * Swallow version conflict errors Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: [APM] Add error rates to Service Map popovers (elastic#69520) [Security Solution][Detection Engine] - Update exceptions logic (elastic#71512) [Security Solution] Full screen timeline, Collapse event (elastic#71786) [Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist (elastic#71807) [Detection Rules] Add 7.9 rules (elastic#71808) [Search] Add telemetry for data plugin search service (elastic#70677) Add @elastic/safer-lodash-set as an alternative to lodash.set (elastic#67452) [tests] Temporarily skipped to promote snapshot
Hey folks, Looking at this code, it seems the response will also include a
Does this seem right? |
@lukasolson Are you planning to monitor anything via the telemetry service? |
@chrisonline, is that a problem? |
@lizozom I ask because I don't see an issue in the Telemetry repo asking to update the mapping for this issue. ui-metrics don't have a schema and we need issues requesting an update to the mapping with the shape of the data we are shipping from Kibana. |
@lizozom It's causing an issue with monitoring parity tests between legacy and metricbeat collection. I don't think it is related to the different collection methods, but rather an issue of the data being available sometimes and not always. Ideally, if the |
@TinaHeiligers @lukasolson we'll open an issue for that. |
@lizozom Sorry, I did some more digging and I'm not sure this has anything to do with this code. I think it's more of a matter of keys colliding when merging telemetry data, which could be a bigger issue, but I'm still looking into it |
}); | ||
|
||
return response.hits.hits.length | ||
? (response.hits.hits[0]._source as Usage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This as Usage
cast is not true.
_source
is returning something like:
{
"references": [],
"updated_at": "2020-08-17T10:53:00.318Z",
"search-telemetry": {
"successCount": 2,
"errorCount": 0,
"averageDuration": 110
},
"type": "search-telemetry"
}
Summary
Relies on #69333.
Partially addresses #62964.
Adds telemetry for data plugin search service. It currently tracks the following events:
To do