Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] User Artifact Mapping Fixes #71449

Merged
merged 1 commit into from
Jul 13, 2020
Merged

[Security Solution][Endpoint] User Artifact Mapping Fixes #71449

merged 1 commit into from
Jul 13, 2020

Conversation

madirey
Copy link
Contributor

@madirey madirey commented Jul 13, 2020 •
edited
Loading

Summary

Addresses the following:

Checklist

N/A

For maintainers

@madirey madirey added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jul 13, 2020
@madirey madirey requested review from a team as code owners July 13, 2020 14:25
@madirey
Copy link
Contributor Author

madirey commented Jul 13, 2020

@EricDavisX

@madirey madirey mentioned this pull request Jul 13, 2020
Merged
marshallmain
marshallmain reviewed Jul 13, 2020
View reviewed changes
x-pack/plugins/security_solution/server/endpoint/lib/artifacts/common.ts
@@ -7,13 +7,13 @@ import { Logger } from 'src/core/server';

export const ArtifactConstants = {
GLOBAL_ALLOWLIST_NAME: 'endpoint-exceptionlist',
SAVED_OBJECT_TYPE: 'endpoint:user-artifact:v2',
SAVED_OBJECT_TYPE: 'endpoint:user-artifact',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why is the v2 being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marshallmain It was just there to help with testing during dev... things were changing quickly and people were not always starting with a fresh install. I had gotten some feedback on it, and I think this is a good time to remove it before we go down the path toward GA.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

Saved Objects .kibana field count

id value diff baseline
endpoint:user-artifact 10 +10 -
endpoint:user-artifact-manifest 3 +3 -
endpoint:user-artifact-manifest:v2 - -3 3
endpoint:user-artifact:v2 - -10 10
total - -0 -

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey merged commit ced0023 into elastic:master Jul 13, 2020
@madirey madirey mentioned this pull request Jul 13, 2020
Merged
madirey added a commit that referenced this pull request Jul 13, 2020
@madirey
Mapping adjustments (#71449) (#71507)
9ba9652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshallmain marshallmain marshallmain left review comments

@alexk307 alexk307 alexk307 approved these changes

@peluja1012 peluja1012 peluja1012 approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madirey @kibanamachine @peluja1012 @alexk307 @marshallmain