Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #71849

Merged
merged 4 commits into from
Jul 15, 2020
Merged

Cleanup #71849

merged 4 commits into from
Jul 15, 2020

Conversation

streamich
Copy link
Contributor

  • Adjusts CODEOWNERS file
  • Renames whitelist to allow-list in data plugin

@streamich streamich requested a review from a team as a code owner July 15, 2020 11:52
@streamich streamich added release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.10.0 v8.0.0 labels Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Added comment on an example that was removed

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_empty_screen·js.dashboard mode empty dashboard "before all" hook for "adds Lens visualization to empty dashboard"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:15:10]         └-: dashboard mode
[00:15:10]           └-> "before all" hook
[00:19:35]           └-: empty dashboard
[00:19:35]             └-> "before all" hook
[00:19:35]             └-> "before all" hook
[00:19:35]               │ info [logstash_functional] Loading "mappings.json"
[00:19:35]               │ info [logstash_functional] Loading "data.json.gz"
[00:19:35]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:19:35]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:19:35]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:19:37]               │ info [lens/basic] Loading "mappings.json"
[00:19:37]               │ info [lens/basic] Loading "data.json.gz"
[00:19:37]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594836837460135335] [.kibana_1/ZOfhqFpqTzu2McUbfqnKQQ] deleting index
[00:19:37]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594836837460135335] [.kibana_2/_e1Oo2ejQ_qIAJ2XUzp98Q] deleting index
[00:19:37]               │ info [lens/basic] Deleted existing index [".kibana_2",".kibana_1"]
[00:19:37]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594836837460135335] [.kibana] creating index, cause [auto(bulk api)], templates [], shards [1]/[1]
[00:19:37]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/dashboard mode empty dashboard _before all_ hook.png"
[00:19:37]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594836837460135335] [.kibana/9s_pY7LNS7aX3AQsNROpaw] create_mapping
[00:19:39]               │ info Current URL is: http://localhost:6181/app/dashboards#/view/46e50c00-c6ce-11ea-a63f-13c4793bc92d?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(description:%27%27,filters:!((%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,formattedValue:%270%27,index:%27logstash-*%27,key:memory,negate:!f,params:(gte:0,lt:40000),type:range),range:(memory:(gte:0,lt:40000)))),fullScreenMode:!f,options:(hidePanelTitles:!f,useMargins:!t),query:(language:kuery,query:%27%27),timeRestore:!f,title:%27Dashboard%20View%20Mode%20Test%20Dashboard%27,viewMode:view)
[00:19:39]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/dashboard mode empty dashboard _before all_ hook.html
[00:19:39]               └- ✖ fail: dashboard mode empty dashboard "before all" hook for "adds Lens visualization to empty dashboard"
[00:19:39]               │      Error: [invalid_alias_name_exception] Invalid alias name [.kibana], an index exists with the same name as the alias, with { index_uuid="9s_pY7LNS7aX3AQsNROpaw" & index=".kibana" }
[00:19:39]               │       at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:19:39]               │       at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:19:39]               │       at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:19:39]               │       at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4929:19)
[00:19:39]               │       at endReadableNT (_stream_readable.js:1145:12)
[00:19:39]               │       at process._tickCallback (internal/process/next_tick.js:63:19)
[00:19:39]               │ 
[00:19:39]               │ 

Stack Trace

{ Error: [invalid_alias_name_exception] Invalid alias name [.kibana], an index exists with the same name as the alias, with { index_uuid="9s_pY7LNS7aX3AQsNROpaw" & index=".kibana" }
    at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
    at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
    at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
    at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4929:19)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  status: 400,
  displayName: 'BadRequest',
  message:
   '[invalid_alias_name_exception] Invalid alias name [.kibana], an index exists with the same name as the alias, with { index_uuid="9s_pY7LNS7aX3AQsNROpaw" & index=".kibana" }',
  path: '/.kibana_1',
  query: {},
  body:
   { error:
      { root_cause: [Array],
        type: 'invalid_alias_name_exception',
        reason:
         'Invalid alias name [.kibana], an index exists with the same name as the alias',
        index_uuid: '9s_pY7LNS7aX3AQsNROpaw',
        index: '.kibana' },
     status: 400 },
  statusCode: 400,
  response:
   '{"error":{"root_cause":[{"type":"invalid_alias_name_exception","reason":"Invalid alias name [.kibana], an index exists with the same name as the alias","index_uuid":"9s_pY7LNS7aX3AQsNROpaw","index":".kibana"}],"type":"invalid_alias_name_exception","reason":"Invalid alias name [.kibana], an index exists with the same name as the alias","index_uuid":"9s_pY7LNS7aX3AQsNROpaw","index":".kibana"},"status":400}',
  toString: [Function],
  toJSON: [Function] }

Build metrics

page load bundle size

id value diff baseline
data 1.5MB -12.0B 1.5MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit a3767d2 into elastic:master Jul 15, 2020
@streamich streamich added v7.9.0 and removed v7.10.0 labels Jul 15, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
* master: (37 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
…feature-privileges

* alerting/consumer-based-rbac: (491 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
streamich added a commit that referenced this pull request Jul 16, 2020
* chore: 🤖 update codeowners file

* refactor: 💡 rename whitelist -> allow-list in data plugin

* Update .github/CODEOWNERS

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants