Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] ignore compressed files when reporting stats #71940

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 15, 2020

I noticed on a few PRs that some random miscellaneous file size changes were being reported on PRs when they shouldn't be changing. Turns out this is because the miscellaneous assets size metric was including the .br and .gz file sizes created in --dist mode. I wasn't testing --dist mode which is why I didn't notice this earlier. I've disabled the reporting of the miscellaneous assets size metric temporarily server side until we get this fix merged.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels Jul 15, 2020
@spalger spalger requested a review from a team as a code owner July 15, 2020 19:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
advancedSettings 67.7KB -21.3KB 89.0KB
apm 3.7MB -1.5MB 5.2MB
beats_management 422.5KB -113.1KB 535.6KB
canvas 1.6MB -513.1KB 2.1MB
charts 62.6KB -11.3KB 73.9KB
console 1.1MB -460.5KB 1.6MB
crossClusterReplication 473.7KB -113.0KB 586.7KB
devTools 6.4KB -3.2KB 9.6KB
discover 444.6KB -166.5KB 611.1KB
enterpriseSearch 150.2KB -57.2KB 207.4KB
graph 1.4MB -620.9KB 2.0MB
grokdebugger 698.1KB -303.3KB 1001.4KB
home 526.0KB -188.0KB 714.0KB
indexLifecycleManagement 279.7KB -79.7KB 359.4KB
indexManagement 1.5MB -499.6KB 2.0MB
indexPatternManagement 703.3KB -270.1KB 973.4KB
infra 3.6MB -1.1MB 4.7MB
ingestManager 1.1MB -390.8KB 1.5MB
ingestPipelines 579.6KB -179.5KB 759.0KB
kibanaLegacy 153.1KB -36.4KB 189.6KB
lens 24.7KB -11.1KB 35.8KB
licenseManagement 170.8KB -55.3KB 226.1KB
logstash 216.4KB -81.1KB 297.5KB
management 176.8KB -78.5KB 255.3KB
maps 3.9MB -1.4MB 5.2MB
ml 15.1KB -6.3KB 21.4KB
monitoring 1.2MB -307.3KB 1.5MB
observability 313.1KB -127.8KB 440.9KB
painlessLab 183.4KB -79.6KB 263.0KB
regionMap 62.6KB -11.3KB 73.9KB
remoteClusters 380.3KB -133.7KB 514.0KB
rollup 338.5KB -97.6KB 436.2KB
savedObjectsManagement 171.5KB -61.4KB 232.9KB
searchprofiler 714.0KB -311.1KB 1.0MB
security 1.1MB -361.5KB 1.4MB
securitySolution 7.3MB -2.0MB 9.3MB
snapshotRestore 763.5KB -184.2KB 947.7KB
spaces 50.4KB -13.5KB 63.9KB
tileMap 62.6KB -11.3KB 73.9KB
timelion 586.1KB -254.1KB 840.2KB
transform 712.4KB -235.1KB 947.4KB
triggers_actions_ui 703.2KB -222.2KB 925.3KB
upgradeAssistant 326.2KB -117.0KB 443.2KB
uptime 631.9KB -206.2KB 838.2KB
visTypeMarkdown 58.5KB -8.9KB 67.4KB
visTypeMetric 56.5KB -7.9KB 64.4KB
visTypeTable 63.1KB -11.3KB 74.4KB
visTypeTagcloud 56.5KB -7.9KB 64.4KB
visTypeTimelion 56.5KB -7.9KB 64.4KB
visTypeTimeseries 1.8MB -646.2KB 2.4MB
visTypeVega 1.4MB -670.0KB 2.1MB
visTypeVislib 56.5KB -7.9KB 64.4KB
visualize 701.2KB -232.6KB 933.8KB
watcher 609.3KB -186.2KB 795.5KB
total - -14.4MB -

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 913d6b1 into elastic:master Jul 15, 2020
@spalger spalger deleted the fix/kbn-optimizer-reporting-compressed branch July 15, 2020 21:27
spalger added a commit to spalger/kibana that referenced this pull request Jul 15, 2020
…#71940)

Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Jul 15, 2020
…71940) (#71968)

Co-authored-by: spalger <spalger@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
* master: (37 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
…feature-privileges

* alerting/consumer-based-rbac: (491 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants