Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard First] Unlink from Library Action #73899

Closed

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Jul 30, 2020

Summary

Adds an embeddable panel action to unlink by reference embeddables from their library item, turning them into by value embeddables. This action should work with any embeddable that uses the attribute service pattern from #68719, where the 'by value' version of the embeddable contains the savedObjectAttributes written out in the 'attributes' key. This connection will be made more explicit in a follow up PR.

TODO

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:roadmap Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.10.0 labels Jul 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
dashboard 174 +1 173

page load bundle size

id value diff baseline
dashboard 685.1KB +7.0KB 678.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

Closed in favor of #74905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants